Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

versions are not increasing #20

Closed
dlangille opened this issue Jun 26, 2021 · 5 comments
Closed

versions are not increasing #20

dlangille opened this issue Jun 26, 2021 · 5 comments

Comments

@dlangille
Copy link

The most recent release version is not greater than the release before it. This causes issues with dependencies.

0.201 was released after 0.200014

For example, on FreeBSD, we get:

$ pkg version --test-version 0.201 0.200014
<

Which means 0.201 < 0.200014.

Would you be able to create a new release please?

@rjbs
Copy link
Owner

rjbs commented Jun 26, 2021

Yes. This is an incorrect comparison, in Perl version semantics, but I knew that this was a possibility. I will make a new release.

@rjbs
Copy link
Owner

rjbs commented Jun 26, 2021

I have released version 1.000

@rjbs rjbs closed this as completed Jun 26, 2021
freebsd-git pushed a commit to freebsd/freebsd-ports that referenced this issue Jun 26, 2021
The previous commit used a release from upsteam which did not increment.
This broke the build for mail/p5-Email-Sender which requires
p5-Throwable>=0.200003

Upstream issue: rjbs/Throwable#20

Approved by:	portmgr blanket
@karenetheridge
Copy link

@dlangille what tools are you using that result in that comparison being false? We should try to fix them, because they are wrong.

@dlangille
Copy link
Author

I am using FreeBSD's pkg command

What makes you think they are wrong?

@Grinnz
Copy link

Grinnz commented Jun 26, 2021

Perl floating-point versions (versions with no leading v and at most one decimal point) cannot be directly translated to integer-tuple version systems like FreeBSD's. The correct translation to an integer-tuple is to translate every 3 decimal places to an integer, so this version would be 0.201.0 and the previous version would be 0.200.14. However, if it does have a leading v or more than one decimal point, it's an integer-tuple form already and needs no translation. See http://blogs.perl.org/users/grinnz/2018/04/a-guide-to-versions-in-perl.html for more info.

mekanix pushed a commit to mekanix/freebsd-ports that referenced this issue Jun 27, 2021
The previous commit used a release from upsteam which did not increment.
This broke the build for mail/p5-Email-Sender which requires
p5-Throwable>=0.200003

Upstream issue: rjbs/Throwable#20

Approved by:	portmgr blanket
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants