Merge pull request sartak#15 from tsibley/ssh-special-characters

Handle special characters in filenames under the SSH service

Makefile.PL

@@ -14,6 +14,7 @@ requires       'Module::Pluggable';
 requires       'Moose' => '0.74';
 requires       'MooseX::Getopt' => '0.17';
 requires       'Class::Load';
+requires       'URI::Escape';
 
 features(
     'pastebin.com support' => [

lib/App/Nopaste/Service/ssh.pm

@@ -5,6 +5,7 @@ use base 'App::Nopaste::Service';
 use File::Temp;
 use File::Spec;
 use POSIX qw(strftime);
+use URI::Escape qw(uri_escape);
 
 sub run {
     my ($self, %args) = @_;
@@ -28,15 +29,17 @@ sub run {
             my ($vol, $dirs, $file) = File::Spec->splitpath($source);
             $args{'desc'} = $file || '';
         }
+        $args{'desc'} =~ s/\s+/+/g; # more readable than %20
         $suffix = ($args{'desc'} ? '-' : '') . $args{'desc'} . $suffix;
     }
 
     my $tmp = File::Temp->new(
         TEMPLATE => "${date}XXXXXXXX",
         SUFFIX   => $suffix,
         UNLINK   => 1,
+        TMPDIR   => 1,
     );
-    my $filename = $tmp->filename;
+    my $filename = File::Spec->rel2abs($tmp->filename);
 
     print $tmp $args{text}
         or return (0, "Can't write to tempfile $filename");
@@ -49,6 +52,9 @@ sub run {
     system('scp', '-pq', $filename, "$server:$docroot");
 
     my ($volume, $dir, $file) = File::Spec->splitpath($filename);
+    $file = uri_escape($file);
+    $file =~ s/%2b/+/gi;
+
     return (1, "$topurl/$file");
 }