Skip to content

Commit

Permalink
Make xtests pass
Browse files Browse the repository at this point in the history
Solve/quiet Perl::Critic and fix spelling/stopwords
  • Loading branch information
xdg committed Feb 2, 2012
1 parent a3ad382 commit 9a8e1b2
Show file tree
Hide file tree
Showing 4 changed files with 29 additions and 7 deletions.
2 changes: 1 addition & 1 deletion README.pod
Expand Up @@ -160,7 +160,7 @@ CORE::GLOBAL::caller, you are probably asking for trouble.
You B<should> load Sub::Uplevel as early as possible within your program. As
with all CORE::GLOBAL overloading, the overload will not affect modules that
have already been compiled prior to the overload. One module that often is
unavoidably loaded prior to Sub::Uplevel is Exporter. To forceably recompile
unavoidably loaded prior to Sub::Uplevel is Exporter. To forcibly recompile
Exporter (and Exporter::Heavy) after loading Sub::Uplevel, use it with the
":aggressive" tag:

Expand Down
5 changes: 4 additions & 1 deletion dist.ini
Expand Up @@ -5,4 +5,7 @@ license = Perl_5
copyright_holder = Michael Schwern and David Golden

[@DAGOLDEN]

stopwords = PadWalker
stopwords = Tcl's
stopwords = Welch
stopwords = uplevel
9 changes: 4 additions & 5 deletions lib/Sub/Uplevel.pm
@@ -1,9 +1,8 @@
package Sub::Uplevel;
# ABSTRACT: apparently run a function in a higher stack frame
# VERSION

use 5.006;
use strict;
# ABSTRACT: apparently run a function in a higher stack frame
# VERSION

# Frame check global constant
our $CHECK_FRAMES;
Expand All @@ -23,7 +22,7 @@ if ( not defined *CORE::GLOBAL::caller{CODE} ) {
my @reload_list = qw/Exporter Exporter::Heavy/;

sub import {
no strict 'refs';
no strict 'refs'; ## no critic
my ($class, @args) = @_;
for my $tag ( @args, 'uplevel' ) {
if ( $tag eq 'uplevel' ) {
Expand Down Expand Up @@ -303,7 +302,7 @@ CORE::GLOBAL::caller, you are probably asking for trouble.
You B<should> load Sub::Uplevel as early as possible within your program. As
with all CORE::GLOBAL overloading, the overload will not affect modules that
have already been compiled prior to the overload. One module that often is
unavoidably loaded prior to Sub::Uplevel is Exporter. To forceably recompile
unavoidably loaded prior to Sub::Uplevel is Exporter. To forcibly recompile
Exporter (and Exporter::Heavy) after loading Sub::Uplevel, use it with the
":aggressive" tag:
Expand Down
20 changes: 20 additions & 0 deletions perlcritic.rc
@@ -0,0 +1,20 @@
severity = 5
verbose = 8

[Variables::ProhibitPunctuationVars]
allow = $@ $!

# Turn these off
[-BuiltinFunctions::ProhibitStringyEval]
[-ControlStructures::ProhibitPostfixControls]
[-ControlStructures::ProhibitUnlessBlocks]
[-Documentation::RequirePodSections]
[-InputOutput::ProhibitInteractiveTest]
[-Miscellanea::RequireRcsKeywords]
[-References::ProhibitDoubleSigils]
[-RegularExpressions::RequireExtendedFormatting]
[-InputOutput::ProhibitTwoArgOpen]

# Turn this on
[Lax::ProhibitStringyEval::ExceptForRequire]

0 comments on commit 9a8e1b2

Please sign in to comment.