Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tree: rework merging inactive watchpoints from child to parent trees #64

Closed
rjeczalik opened this issue Feb 5, 2015 · 0 comments
Closed
Assignees
Labels

Comments

@rjeczalik
Copy link
Owner

When the same chan is used to watch both watchpoints, the child and parent one, the latter will get overwritten with inactive flag coming from the child.

Quick fix would be to drop the inactive flag for this chan, however this would require maintaining temporary unique set of user chans for each dispatch to ensure single event is not dispatched multiple times to the same channel.

The proper fix would be to rework recursiveTree to not story inactive watchpoints altogether with active ones. In order to not hack the node struct, best place would be (node).Child[""].Watch, as empty-string keys are never traversed.

@rjeczalik rjeczalik added the bug label Feb 5, 2015
rjeczalik added a commit that referenced this issue Feb 5, 2015
@rjeczalik rjeczalik self-assigned this Feb 6, 2015
rjeczalik added a commit that referenced this issue Feb 7, 2015
tree: rework merging inactive watchpoints from child to parent trees

closes #64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant