-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
noHtml5Validate should be true by default #1184
Comments
That's a good point. I'm wondering whether it's worth it to introduce this change at this point, since it really might cause some backwards-incompatible behavior and it's not too hard to work around it right now. What do you think @glasserc @edi9999 @LucianBuzzo ? |
I think like you, it is a good idea but since it is backwards incompatible, it should be done in v2 only |
@edi9999 @epicfaace This interaction is pretty horrible, especially for checkbox/boolean fields. It's definitely a breaking change though, so it should coincide with a major version bump of the npm package. |
+1 for disabling html5 validation by default in V2 I wonder if there's a legitimate need for HTML5 validation? If no, the |
I would be OK with disabling HTML5 validation in V2. |
By default, displaying html 5 validations on forms provides a much more intuitive user experience and ensures a standardized method for generating and displaying form validation errors fixes rjsf-team#1184 BREAKING_CHANGE
By default, displaying html 5 validations on forms provides a much more intuitive user experience and ensures a standardized method for generating and displaying form validation errors fixes rjsf-team#1184 BREAKING_CHANGE
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please leave a comment if this is still an issue for you. Thank you. |
Prerequisites
Description
The default HTML5 validation makes for a confusing UX. For end users, the styling and behavior is inconsistent with the rest of the library (see n1k0's comment here). For developers who are new to react-jsonschema-form, it makes for a puzzling situation when you try to customize how errors are displayed.
Steps to Reproduce
In Chrome:
Expected behavior
react-jsonschema-form should have displayed its normal error handling.
Actual behavior
The default html5 form validation overrode the normal error handling.
Version
1.2.1
You can usually get this information in your
package.json
or in the file URL if you're using the unpkg one.The text was updated successfully, but these errors were encountered: