Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "git add" commands from lint-staged #1828

Closed
epicfaace opened this issue Jun 25, 2020 · 14 comments
Closed

Remove "git add" commands from lint-staged #1828

epicfaace opened this issue Jun 25, 2020 · 14 comments

Comments

@epicfaace
Copy link
Member

I get this warning when committing:

@rjsf/core: ⚠ Some of your tasks use `git add` command. Please remove it from the config since all modifications made by tasks will be automatically added to the git commit index.
@ExplorerAadi
Copy link

Okay, I will pick this up

@OlushesiToheeb
Copy link
Contributor

I'll like to work on this @epicfaace

@galanggg
Copy link
Contributor

galanggg commented Mar 8, 2021

Hi @epicfaace , is this issue still available?

@epicfaace
Copy link
Member Author

Yes, it is!

@OlushesiToheeb
Copy link
Contributor

@galanggg are you working on this already? had forgot i commented on this

@galanggg
Copy link
Contributor

galanggg commented Mar 8, 2021

I happen to be working on it, do you still want to take this issue? @OlushesiToheeb

@OlushesiToheeb
Copy link
Contributor

@galanggg Yes I'll love to and @epicfaace I saw the git add in core , material ui and semantic ui package.json lintstage should I just remove it in all, push to a new branch and make a pull request?

@epicfaace
Copy link
Member Author

Yes, please do!

@OlushesiToheeb
Copy link
Contributor

@epicfaace they're some are I'm facing here , the first image was when trying to do npm install just prettier config but I got that error then the second was when i was trying to commit my changes. kindly check out and let me know what I should have done or what I'm doing wrong.
image
image

@epicfaace
Copy link
Member Author

Did you run npm install from the root directory first?

@epicfaace
Copy link
Member Author

epicfaace commented Mar 9, 2021

Also, I think your first screenshot cuts off the actual error message. Can you send me what you meant there?

@takumawatanabe-0920
Copy link

@epicfaace
If you are still experiencing this bug, may I try?

@epicfaace
Copy link
Member Author

Sure!

@v8686561728
Copy link

v8686561728 commented Jul 30, 2022

Hi @takumawatanabe-0920

This issue has been resolved by @OlushesiToheeb in this PR on Mar 20, 2021.

@epicfaace could you please close this issue

@nickgros nickgros closed this as completed Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants