Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdditionalProperties are not supported in FluentUI template #2777

Closed
3 tasks done
martinlaukkanen opened this issue Mar 23, 2022 · 0 comments · Fixed by #3626
Closed
3 tasks done

AdditionalProperties are not supported in FluentUI template #2777

martinlaukkanen opened this issue Mar 23, 2022 · 0 comments · Fixed by #3626
Labels
bug fluent-ui fluent-ui related theme issue help wanted

Comments

@martinlaukkanen
Copy link

Prerequisites

Description

Hello,
AdditionalProperties do not work in the Fluent UI template, I've followed this issue tracked here for Semantic-ui Bootstrap4 and fluentUI in #1927 plus for MaterialUI #1724 and unfortunately the Fluent version never happened.

So I'm just going to log this here as an open item. I'd love to contribute to this, but time won't be on my side.. :(

Steps to Reproduce

  1. Goto https://rjsf-team.github.io/react-jsonschema-form/
  2. Select additionalProperties example
  3. Select theme fluent-ui

Expected behavior

image

Actual behavior

Additional properties section has no add new row or remove row.

Version

^4.1.0

@jacqueswho jacqueswho added bug fluent-ui fluent-ui related theme issue labels Apr 7, 2022
tjasz added a commit to tjasz/react-jsonschema-form that referenced this issue Apr 26, 2023
Fixes rjsf-team#2777.
Adds "Add Item" button to objects that support additional properties.
Adds editable key and a remove button to additional properties.

Add entry to changelog
tjasz added a commit to tjasz/react-jsonschema-form that referenced this issue Apr 26, 2023
Fixes rjsf-team#2777.

- Adds "Add Item" button to objects that support additional properties.
- Adds editable key and a remove button to additional properties.
tjasz added a commit to tjasz/react-jsonschema-form that referenced this issue Apr 26, 2023
Fixes rjsf-team#2777.

- Adds "Add Item" button to objects that support additional properties.
- Adds editable key and a remove button to additional properties.
heath-freenome pushed a commit that referenced this issue Apr 27, 2023
* Add additionalProperties support to fluent-ui theme

Fixes #2777.

- Adds "Add Item" button to objects that support additional properties.
- Adds editable key and a remove button to additional properties.

* Move div from FieldTemplate into WrapIfAdditionalTemplate

* Remove ID from non-additional div

---------

Co-authored-by: tjaszkowiak <tjaszkowiak@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fluent-ui fluent-ui related theme issue help wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants