Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Antd theme empty space #3174

Closed
3 of 4 tasks
v1ack opened this issue Oct 3, 2022 · 0 comments · Fixed by #3187
Closed
3 of 4 tasks

Antd theme empty space #3174

v1ack opened this issue Oct 3, 2022 · 0 comments · Fixed by #3187
Labels
bug

Comments

@v1ack
Copy link
Contributor

v1ack commented Oct 3, 2022

Prerequisites

What theme are you using?

antd

Version

5.0.0-beta.10

Current Behavior

Empty space between input and description
Снимок экрана 2022-10-04 в 00 13 29

Expected Behavior

Снимок экрана 2022-10-04 в 00 17 06

Steps To Reproduce

No response

Environment

- OS:
- Node:
- npm:

Anything else?

Looks like it can be fixed by replacing in field template

react-jsonschema-form/packages/antd/src/templates/FieldTemplate/index.tsx

Line 71 in 4adf86a

help={(!!rawHelp && help) || errors}

to

help={(!!rawHelp && help) || (rawErrors?.length && errors) || undefined}
@v1ack v1ack added bug needs triage Initial label given, to be assigned correct labels and assigned labels Oct 3, 2022
@heath-freenome heath-freenome removed the needs triage Initial label given, to be assigned correct labels and assigned label Oct 7, 2022
heath-freenome added a commit to heath-freenome/react-jsonschema-form that referenced this issue Oct 7, 2022
@heath-freenome
Fix rjsf-team#3174 by not rendering empty help and extra information …
af44e3b 
…for fields

Fixed rjsf-team#3174
- Updated `FieldTemplate` to ensure that `help` and `extra` information is only rendered when the `rawDescription` and `rawErrors` are not provided
  - Before, even though `description` and `errors` would render empty components, it would still cause unnecessary whitespace in which they were rendered
  - Now, those props are passed undefined unless the raw information indicates there is data to render
- Updated the test snapshots
- Updated the `CHANGELOG.md` accordingly
@heath-freenome heath-freenome mentioned this issue Oct 7, 2022
Merged
8 tasks
heath-freenome added a commit to heath-freenome/react-jsonschema-form that referenced this issue Oct 7, 2022
@heath-freenome
Fix rjsf-team#3174 by not rendering empty help and extra information …
dcc1a41 
…for fields

Fixed rjsf-team#3174
- Updated `FieldTemplate` to ensure that `help` and `extra` information is only rendered when the `rawDescription` and `rawErrors` are not provided
  - Before, even though `description` and `errors` would render empty components, it would still cause unnecessary whitespace in which they were rendered
  - Now, those props are passed undefined unless the raw information indicates there is data to render
- Updated the test snapshots
- Updated the `CHANGELOG.md` accordingly
heath-freenome added a commit that referenced this issue Oct 7, 2022
@heath-freenome
Fix #3174 by not rendering empty help and extra information for fields (
6666b18 
#3187)

Fixed #3174
- Updated `FieldTemplate` to ensure that `help` and `extra` information is only rendered when the `rawDescription` and `rawErrors` are not provided
  - Before, even though `description` and `errors` would render empty components, it would still cause unnecessary whitespace in which they were rendered
  - Now, those props are passed undefined unless the raw information indicates there is data to render
- Updated the test snapshots
- Updated the `CHANGELOG.md` accordingly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
2 participants
@v1ack @heath-freenome