Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@rjsf/playground: Vite dev server broken #3228

Closed
4 tasks done
nickgros opened this issue Nov 4, 2022 · 0 comments · Fixed by #3229
Closed
4 tasks done

@rjsf/playground: Vite dev server broken #3228

nickgros opened this issue Nov 4, 2022 · 0 comments · Fixed by #3229
Labels
bug needs triage Initial label given, to be assigned correct labels and assigned

Comments

@nickgros
Copy link
Contributor

nickgros commented Nov 4, 2022

Prerequisites

What theme are you using?

core

Version

5.0.0-beta12

Current Behavior

global is not defined

Expected Behavior

No response

Steps To Reproduce

No response

Environment

- OS:
- Node:
- npm:

Anything else?

No response

@nickgros nickgros added bug needs triage Initial label given, to be assigned correct labels and assigned labels Nov 4, 2022
nickgros added a commit to nickgros/react-jsonschema-form that referenced this issue Nov 4, 2022
- Fix vite dev server
- Assign `globalThis` to window.global to fix issue in semantic
- ajv-formats `addFormats` should not be called with a nullish value
nickgros added a commit to nickgros/react-jsonschema-form that referenced this issue Nov 5, 2022
Playground
- Playground `localValidator` should use @rjsf/validator-ajv8
- Upgrade Vite and @vitejs/plugin-react to latest

@rjsf/validator-ajv8
- Alias `ajv` to `ajv8` because in the playground, Vite erroneously imports Ajv 6
- Report any schema error thrown by Ajv
- Disable Ajv's strict mode by default
- Add RJSF-specific additional properties keywords to Ajv to prevent errors from being reported in strict mode.
-
nickgros added a commit that referenced this issue Nov 5, 2022
nickgros added a commit to nickgros/react-jsonschema-form that referenced this issue Jan 13, 2023
- Upgrade vite to 4.0.4
- Remove ajv8 alias for validator-ajv8 (will fix issues in skypack)
- Change vite mode to production (fixes issue where vite/esbuild mix up ajv v6 and v8)
nickgros added a commit to nickgros/react-jsonschema-form that referenced this issue Jan 13, 2023
- Upgrade vite to 4.0.4
- Remove ajv8 alias for validator-ajv8 (will fix issues in skypack)
- Change vite mode to production (fixes issue where vite/esbuild mix up ajv v6 and v8)
nickgros added a commit to nickgros/react-jsonschema-form that referenced this issue Jan 14, 2023
- Upgrade vite to 4.0.4
- Remove ajv8 alias for validator-ajv8 (will fix issues in skypack)
- Change vite mode to production (fixes issue where vite/esbuild mix up ajv v6 and v8)
heath-freenome pushed a commit that referenced this issue Jan 14, 2023
* Re-fix #3228 and related follow-up issues
- Upgrade vite to 4.0.4
- Remove ajv8 alias for validator-ajv8 (will fix issues in skypack)
- Change vite mode to production (fixes issue where vite/esbuild mix up ajv v6 and v8)

* Update lockfile

* `preserveSymlinks` seems to fix rather than changing `mode`

* Update CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug needs triage Initial label given, to be assigned correct labels and assigned
Projects
None yet
1 participant