extraErrors not working properly

[Sourcekot]

Prerequisites

• I have searched the existing issues
• I understand that providing a SSCCE example is tremendously useful to the maintainers.
• I have read the documentation
• Ideally, I'm providing a sample JSFiddle, Codesandbox.io or preferably a shared playground link demonstrating the issue.

What theme are you using?

mui

Version

5.8.2

Current Behavior

extraErrors not available in transformErrors and focusOnFirstError
extraErrors in arrays not triggering ErrorListTemplate
The ErrorListTemplate is not called again on a submit if the errors didn't change

Expected Behavior

extraErrors should be included in the errors of transformErrors and focusOnFirstError
extraErrors in arrays should trigger ErrorListTemplate
The ErrorListTemplate should be called again on a submit even if the errors didn't change (but I would understand if that behaviour is not wanted)

Steps To Reproduce

https://codesandbox.io/s/bold-wescoff-stm77h

In the codesandbox I'm adding an extraError when the submit button is pressed. You will see that its message is correctly displayed below the field. But there are the following problems with it:

1. The errors in transformErrors are not containing the extraErrors (errors.length is 0) -> The extraError message is not transformed.
2. Same for focusOnFirstError. In the codesandbox it is never reached as there is only an extraError and no "real" errors.

You can see that both transformErrors and focusOnFirstError are reached and contain an error if you clear the field and press submit. The default required check is done and it's message will be transformed to "Error transformed". In the console you can see that focusOnFirstError was also reached as it logged the error object.

3. In the example the added ErrorListTemplate is only called after the first submit and not after any additional submits. In my project it isn't even called once for the extraErrors. I'm guessing that this might be caused by the field being in an array (type: "array", items -> type: "object", properties -> ...) but I couldn't get that to work properly in the codesandbox. I can see in the onSubmit function that there are extraErrors and that they are added correctly. The error messages at the fields are also displayed correctly but somehow the ErrorListTemplate is never called for them.
   But even the behaviour from the codesandbox wouldn't be much better in my project. It might be the wanted behaviour to not call it again if nothing changed but in my case that would be a problem. I'm using a snackbar in the ErrorListTemplate which is only displayed for a few seconds. It will not be displayed again if there where no changes to the errors.

Environment

- OS: Microsoft Windows 10 Pro, Version	10.0.19044 Build 19044
- Node: 16.15.0
- npm: 8.18.0

Anything else?

No response

[heath-freenome]

@Sourcekot You found a small bug with focusOnFirstError that I will be fixing momentarily so that it gets the extraErrors. As for transformErrors, that is only called by the validator-ajv(6|8) on the errors returned from the AJV validator. It is assumed that your extraErrors have already been transformed by whatever means you need for the AJV errors.

[Sourcekot]

Sadly my problems were only partially fixed and some new problems now occur:

Codesandbox: https://codesandbox.io/s/solitary-breeze-7ykd2f

1. focusOnFirstError is only reached when I'm pressing submit for a second time.
2. onSubmit is only called once, try the following in the codesandbox: Fill the field and press submit, it will show "ExtraError field filled.". Now clear the field and press submit again and the message doesn't change (should have been "ExtraError field not filled."). The console.log in the first line of onSubmit is never reached.
3. If the first error is inside an array the error in focusOnFirstError will be "undefined". See codesandbox: https://codesandbox.io/s/quizzical-butterfly-zsh7v7
   Add a subentry and press submit. It will somehow close after the first submit so add a subentry again and submit again. This time you can see "undefined" in the console as the error object from the focusOnFirstError function.

One more thing: Why is the ErrorListTemplate reached every time I change something in the form? LiveValidate is not enabled so I thought this shouldn't happen.

[heath-freenome]

@Sourcekot Can you open a new issue for these? Thanks!

[Sourcekot]

@Sourcekot Can you open a new issue for these? Thanks!

Of couse, here you go: #3827