Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precompiled Schema not resolving all properties when allOf #3817

Closed
4 tasks done
cwendtxealth opened this issue Aug 10, 2023 · 1 comment · Fixed by #3818
Closed
4 tasks done

Precompiled Schema not resolving all properties when allOf #3817

cwendtxealth opened this issue Aug 10, 2023 · 1 comment · Fixed by #3818
Labels
bug needs triage Initial label given, to be assigned correct labels and assigned

Comments

@cwendtxealth
Copy link
Contributor

Prerequisites

What theme are you using?

core

Version

5.12

Current Behavior

When precompiling a schema with allOf and top level properties with references, those properties will not be resolved and passed through the validator. Example schema

{
  type: 'object',
  properties: {
    test: { $ref: '#/definitions/anyOfTest' }
  },
  allOf: [{
    type: 'object',
    properties: {
      secondField: {
        type: 'string'
      }
    }
  }],
  definitions: {
    anyOfTest: {
      anyOf: [{
        type: 'boolean'
      }, { type: 'string'}]
    }
  }
} 

The allOf will be returned as individual schemas here but the rest of the schema properties are not returned to be resolved.

Expected Behavior

No response

Steps To Reproduce

No response

Environment

- OS:
- Node:
- npm:

Anything else?

No response

@cwendtxealth cwendtxealth added bug needs triage Initial label given, to be assigned correct labels and assigned labels Aug 10, 2023
@cwendtxealth
Copy link
Contributor Author

PR fix incoming

cwendtxealth added a commit to cwendtxealth/react-jsonschema-form that referenced this issue Aug 10, 2023
heath-freenome pushed a commit that referenced this issue Aug 11, 2023
* fix: Fixes #3817 Precompiled schema allOf

* update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug needs triage Initial label given, to be assigned correct labels and assigned
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant