Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash when update to v5.17.0: util could not be found within the project or in these directories #4080

Closed
4 tasks done
thanhcuong1990 opened this issue Feb 5, 2024 · 5 comments · Fixed by #4093
Closed
4 tasks done

Crash when update to v5.17.0: util could not be found within the project or in these directories #4080

thanhcuong1990 opened this issue Feb 5, 2024 · 5 comments · Fixed by #4093
Assignees
@nickgros
Labels
bug p1 Important to fix soon playground utils Related to @rjsf/utils

Comments

@thanhcuong1990
Copy link

Prerequisites

What theme are you using?

core

Version

5.17.0

Current Behavior

Error: Unable to resolve module util from app/node_modules/@rjsf/utils/dist/index.js: util could not be found within the project or in these directories:
node_modules/@rjsf/utils/node_modules

Expected Behavior

No response

Steps To Reproduce

update @rjsf/core and @rjsf/utils from version 5.16.1 to 5.17.0.

Environment

- OS: MacOS 14.3 
- Node: 18.19.0
- npm: 10.2.4

Anything else?

No response
@thanhcuong1990 thanhcuong1990 added bug needs triage Initial label given, to be assigned correct labels and assigned labels Feb 5, 2024
@areski
Copy link

areski commented Feb 5, 2024

I'm getting the same issue as @thanhcuong1990 :

ERROR in ./node_modules/@rjsf/utils/lib/base64.js 17:40-55
Module not found: Error: Can't resolve 'util' in '/xxx/node_modules/@rjsf/utils/lib'

util is coming from node, not sure why this is failing [https://nodejs.org/docs/latest-v20.x/api/util.html#util]

@SarahBocognano SarahBocognano mentioned this issue Feb 12, 2024
Merged
1 task
@fcollonval fcollonval mentioned this issue Feb 16, 2024
Closed
@fcollonval
Copy link

We are getting the same error in JupyterLab. The issue is because we built a browser application and our bundler (webpack) does not know what to do with the NodeJS library import.

@fcollonval
Copy link

Related PR: #4034

@heath-freenome
Copy link
Member

@areski Oh wow, since this capability was really only added for the playground, we will be moving it out of @rjsf/utils in 5.17.1 sorry for the inconvenience. We should have this fix up within the week.

@heath-freenome heath-freenome added playground p1 Important to fix soon utils Related to @rjsf/utils and removed needs triage Initial label given, to be assigned correct labels and assigned labels Feb 16, 2024
nickgros added a commit to nickgros/react-jsonschema-form that referenced this issue Feb 16, 2024
@nickgros
[fix] rjsf-team#4080
3125910 
- Move `base64` encode/decoder object to playground, remove from utils
- Add test script and config to playground
@nickgros nickgros mentioned this issue Feb 16, 2024
Merged
8 tasks
nickgros added a commit that referenced this issue Feb 19, 2024
@nickgros
Fix #4080 by moving base64 encoder/decoder from @rjsf/utils to pl…
e2e37b7 
…ayground (#4093)
@areski
Copy link

areski commented Feb 19, 2024

Thanks a million @nickgros & @heath-freenome

nickgros added a commit that referenced this issue Apr 19, 2024
@nickgros
Merge changes in main to rjsf-v6 (#4164)
0ff0afa 
Co-authored-by: Heath C <51679588+heath-freenome@users.noreply.github.com>
Co-authored-by: Abdallah Al-Soqatri <abdallah.al-soqatri@aspentech.com>
Co-authored-by: Kevin Burnett <18027+burnettk@users.noreply.github.com>
Co-authored-by: Marek Bodinger <marek.bodinger@gmail.com>
Co-authored-by: Mehdi Salem <mehdi.salem@qt.io>
Co-authored-by: Jonasz Wiącek <jonaszwiacek@gmail.com>
Co-authored-by: Bogdan Savluk <savluk.bogdan@gmail.com>
Co-authored-by: Christian Wendt <54559756+cwendtxealth@users.noreply.github.com>
Co-authored-by: Ben Lambert <ben@blam.sh>
Co-authored-by: David R. Bild <david@davidbild.org>
Co-authored-by: Ariqun <38001928+Ariqun@users.noreply.github.com>
Co-authored-by: Shivam Anand Murmu <35562703+Rozamo@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Shubham Biswas <46351104+Shubhcoder@users.noreply.github.com>
Co-authored-by: popmanhe <neo_temp@hotmail.com>
Co-authored-by: Yuki Aoki <me@aoki.app>
Co-authored-by: Xiangcheng Kuo <37873394+orange-guo@users.noreply.github.com>
Co-authored-by: Bart van Andel <bavanandel@gmail.com>
Co-authored-by: Laurent Direr <laurent.direr@gmail.com>
Co-authored-by: Vegard Stenvik <42935080+vstenvik@users.noreply.github.com>
Co-authored-by: Appie <abdallarko@hotmail.com>
Co-authored-by: Oren Forer <oforer@gmail.com>
Co-authored-by: Marcus Penn <11893741+mpenndev@users.noreply.github.com>
Co-authored-by: joachimhagheim <47362824+joachimhagheim@users.noreply.github.com>
Co-authored-by: MarekBodingerBA <104828482+MarekBodingerBA@users.noreply.github.com>
Co-authored-by: momesana <momesana@gmail.com>
Co-authored-by: Martti Roitto <MarttiR@users.noreply.github.com>
fix(utils): direct lodash function import to improve bundling on library client side (#3976)
fix: #3961 resolve all recurse list for object properties (#3981)
fix gap in outline when label is hidden (#3984)
Fix: Expose the internal `ajv` variable in the validator implementation classes (#3991)
Fixes: #3972 indirectly by exposing the `ajv` variable for use in the issue
Fix: Change FormHelperText usage with @mui/material to render divs (#4032)
Fixes #4031 by switching the render component for `FormHelperText` to be `div`
fix: Added support for anyOf/oneOf in uiSchema (#4055)
Fixes #4039 by updating `MultiSchemaField` to properly support `anyOf`/`oneOf` arrays in the `uiSchema`
Fix checkbox with 0 as a value was unselectable in antd (#4068)
Fixed #4067 by properly dealing with enums that have 0 as a value
Fix potential XSS in the preview button of FileWidget (#4065)
Fix: Make 'ui:rows' option work with chakra-ui for textarea elements #4070 (#4078)
Fix typo in ErrorsListTemplate example (#4087)
Fix #4080 by moving `base64` encoder/decoder from `@rjsf/utils` to playground (#4093)
Fix: Error state not resetting when schema changes (#4079) (#4103)
Fix noImplicitAny error (#4106)
Fixes: [WARNING] Duplicate key "include" in object literal [duplicate-object-key] (#4114)
Fixes: Warning: validateDOMNesting(...): <p> cannot appear as a descendant of <p>. (#4117)
Fix documentation to add missing Form imports (#4131)
Fix #4127 to add missing `Form` import in documentation
Fix: filename should be bold (#4125)
Fix: use correct ConfigProvider context by using named imports (#4132)
Fix 4134 by filtering out bad DOM props (#4140)
Fixes: #4134 by updating the spreading of props onto the `TextField` to remove bad DOM fields
Fixed Programmatic submit not working properly in Firefox (#4150)
Fix Maximum call stack size exceeded in findSchemaDefinition (#4123)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nickgros nickgros

Labels
bug p1 Important to fix soon playground utils Related to @rjsf/utils
Projects
None yet
Milestone
No milestone
5 participants
@areski @thanhcuong1990 @fcollonval @nickgros @heath-freenome