Synchronous call to onSubmit() from props

[sbusch]

Reasons for making this change

Due to the use of setImmediate() hack in setState utility function from utils.js,
the onSubmit() handler from props is called asynchronously.

This leads to problems for submit handlers requiring browser "trusted events", like window.open() or
when programmatically submitting forms with target _blank.

Because onSubmit() should not need the performance-related setImmiate() hack, I
replaced call to setState utility function with proper this.setState() from
React, which fixed the problem.

Checklist

• I'm updating documentation
  • I've checked the rendering of the Markdown text I've added
  • If I'm adding a new section, I've updated the Table of Content
• I'm adding or updating code
  • I've added and/or updated tests: couldnt figure out how to properly test this.
  • I've updated docs if needed
  • I've run npm run cs-format on my branch to conform my code to prettier coding style
• I'm adding a new feature
  • I've updated the playground with an example use of the feature

[glasserc]

Thanks!

[althalus86]

Hi guys, I might be mistaken but this commit is breaking my build.

It's throwing a "TypeError: this.updater.enqueueCallback is not a function" when submitting the form.

The code is fairly simple

<Form schema={this.state.schema} onChange={log("changed")} onSubmit={this.onSubmit}

onSubmit is just an empty function

[glasserc]

@althalus86 I'm not a React expert so I don't claim to understand what's going on, but I don't think we have any control over ReactComponent.setState and I don't know what this.updater is or why it would have an enqueueSetState but not an enqueueCallback. If you're still having this problem, feel free to open another issue that refers to this one.

[sbusch]

@althalus86

Do you have a reproducible full example?

Did you install via "npm install react-jsonschema-form"?

Is node_modules/react-jsonschema-form a regular directory or a symlink?

Which react, react-dom and typescript version are you using? (npm ls output for each of them)