Bundle the captures inside a 'screenshot' folder #161
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. After discussion we're not gonna land this. On the other hand I've filed #162 about the intermittent failure you just got with this PR. |
|
For later reference and other people reading: this will not land because it complexifies @n1k0 flow when he's working, as he's using a tool which directly uploads screenshots to imgur. |
James-Brown98
pushed a commit
to James-Brown98/react-jsonschema-form
that referenced
this pull request
Feb 24, 2022
… label, to the definition's title. (rjsf-team#161)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #158
This won't work unless it's merged to master (links are done on the master branch).