Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: exposing findSchemaDefinition out of the utils lib #1643

Merged

Conversation

erunion
Copy link
Collaborator

@erunion erunion commented Mar 11, 2020

Reasons for making this change

Working on some resolving some bugs in a custom SchemaField that we've got, and I needed access to this so I could parse a $ref. Couldn't use it because it wasn't being exposed!

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests
    • I've updated docs if needed
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

Copy link
Member

@epicfaace epicfaace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that does seem to be a useful util to export.

Still thinking about whether we should actually export utils from the same path / package though -- see #1642 (comment) -- but that's a discussion fro later.

@epicfaace epicfaace merged commit ff8b700 into rjsf-team:master Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants