Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid mixing CJS require in ESM modules #2028

Merged
merged 2 commits into from
Dec 10, 2020

Conversation

kuwoyuki
Copy link
Contributor

@kuwoyuki kuwoyuki commented Sep 3, 2020

Reasons for making this change

Fixes #1893
Mixing CommonJS require in ESM modules is incorrect. It works in webpack, however a lot of other bundlers do not support that.

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests
    • I've updated docs if needed
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

Copy link
Member

@epicfaace epicfaace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! I'm not sure why the require statements were there earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

require is not defined
2 participants