Fixed disabled option for antd selects. #2111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @epicfaace , could you take a look? |
epicfaace
approved these changes
Nov 6, 2020
|
Hey @epicfaace, I don't have any permissions to merge this PR, could you merge it? : ) And after merge are we gonna have new version of package with these changes? |
|
Looks good -- just verified it worked on the deploy preview playground. In the future, it will be very helpful if you could directly link to the deploy preview playground so it's quicker to review and verify. Yes, will release a new version soon with this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
I found bug with disabled options for antd select widget.
Checklist