Custom description field #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| You can provide your own implementation of the `DescriptionField` base React component for rendering any description. | ||
|
|
||
|
|
There was a problem hiding this comment.
nit: one empty line too many
|
LGTM with nits addressed. It's a little sad we can't accept react elements as description, but that's definitely not an option in a JSONschema :) |
Among other cosmetic changes, we now pass custom titles and descriptions using the `fields` property (whereas we were passing it directly before, a behaviour now deprecated).
|
I've updated the branch with commits addressing your comments :) |
|
Perfect, thanks o/ |
|
Released as part of v0.31.0. |
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to customize the description using a description field.
This breaks the previous behaviour: it was returning a
pfor ArrayFields anddivsfor ObjectFields. This is now returning adivfor both.I also added some tests in the ArrayField to check that it's able to handle custom TitleFields.
paired with @Natim, r? @n1k0