Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization for error messages #2189

Closed
wants to merge 3 commits into from

Conversation

IgorLesnevskiy
Copy link

@IgorLesnevskiy IgorLesnevskiy commented Jan 5, 2021

Reasons for making this change

Based on #846. Also, may close #1195.
@epicfaace @edi9999 @pieplu, take a look, please. English is not my mother tongue, so feel free to fix my language in the docs.

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests
    • I've updated docs if needed
  • I'm adding a new feature
    • I've updated the playground with example use of the feature

@epicfaace epicfaace self-requested a review January 5, 2021 19:08
@epicfaace epicfaace self-assigned this Jan 5, 2021
@IgorLesnevskiy IgorLesnevskiy changed the title Localization Localization of errors messages Jan 6, 2021
@IgorLesnevskiy IgorLesnevskiy changed the title Localization of errors messages Localization of error messages Jan 6, 2021
@IgorLesnevskiy IgorLesnevskiy changed the title Localization of error messages Localization for error messages Jan 6, 2021
@seemike
Copy link

seemike commented Feb 26, 2021

waiting so much for this feature!

@heath-freenome
Copy link
Member

@epicfaace How goes the review on this? This feature will help many many people

@Ugolaf
Copy link

Ugolaf commented May 4, 2021

@epicfaace Hello, it is possible to fix those little conflicts in order to merge that feature?

@MedinaGitHub
Copy link

waiting so much for this feature!

@epicfaace epicfaace assigned epicfaace and unassigned epicfaace May 25, 2021
@Ugolaf
Copy link

Ugolaf commented Jun 10, 2021

@epicfaace Do you need some help to merge that feature?

@epicfaace
Copy link
Member

@Ugolaf , yeah, I haven't gotten a chance to do a review yet. Some things that would help is if someone could:

  • do a short write-up of how the changes in the PR are designed
  • look through the code to double-check everything is working properly (have sufficient tests, etc.)

This would really speed up my review, as these are the most time-consuming parts of any review.

@geohuz
Copy link

geohuz commented Aug 5, 2021

What is the progress on this issue, we are waiting for the feature to be released.

@Ugolaf Ugolaf mentioned this pull request Sep 29, 2021
8 tasks
@v1talii-dev
Copy link

Игорь, спасибо вам за работу. Подскажите, когда планируется завершить работы по данному PR? Я очень поверхностно знаком с проектом, но если нужна какая-то помощь, готов ее предоставить. Очень хотелось бы иметь данную функциональность в продакшене.

@heath-freenome heath-freenome added the v5 refactor Needs refactor due to v5 breaking changes label Sep 3, 2022
@IgorLesnevskiy
Copy link
Author

IgorLesnevskiy commented Sep 4, 2022

@v1talii-dev я работал над этим полтора года назад, но, насколько вижу, фичу так и не проревьювили. я могу попробовать разобрать конфликты, но я вообще не помню что там было. кроме того, идет работа над версиюе 5.0.0, возможно там это уже реализовано из коробки.

@heath-freenome are you planning to add this feature to the v5? I'm not sure whether I need to resolve the conflicts or not.

@heath-freenome
Copy link
Member

@IgorLesnevskiy I am planning to provide an Ajv 8 version of a validator in the next week or so. I will provide similar capabilities as to what you provided here. I shall add you as a reviewer when I do. I don't believe that adding the feature to the Ajv v6 version of the validator makes sense since that version of Ajv is at the end-of-life.

@IgorLesnevskiy
Copy link
Author

@heath-freenome sounds good, thank you!

@v1talii-dev
Copy link

@IgorLesnevskiy @heath-freenome thank you all!

@heath-freenome
Copy link
Member

@IgorLesnevskiy Ok, I can't seem to add you as a reviewer, but you can check out the new PR here

@IgorLesnevskiy
Copy link
Author

thank you! since there's no need in this mr anymore, I will close it.

@IgorLesnevskiy IgorLesnevskiy deleted the localization branch September 7, 2022 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v5 refactor Needs refactor due to v5 breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

trouble with native compatibility with ajv-i18n
8 participants