Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 3.x upgrade guide.md #2436

Merged
merged 1 commit into from
Jun 27, 2021
Merged

Update 3.x upgrade guide.md #2436

merged 1 commit into from
Jun 27, 2021

Conversation

epicfaace
Copy link
Member

Update upgrade guide to encompass changes in #2360. @bradhugh can you also take a look to ensure this is accurate?

@epicfaace epicfaace merged commit 530ec1f into master Jun 27, 2021
@epicfaace epicfaace deleted the epicfaace-patch-1 branch June 27, 2021 17:46
@bradhugh
Copy link
Contributor

Yes, this is basically right. The normal theme didn't have an id for the help field at all previously but the semantic-ui theme had a bug where the id for the help was the id of the field itself.

epicfaace added a commit that referenced this pull request Jun 28, 2021
@epicfaace
Copy link
Member Author

Thanks for the clarification!

epicfaace added a commit that referenced this pull request Jul 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants