-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load 3.0 codepen examples in documentation once more #2470
Load 3.0 codepen examples in documentation once more #2470
Conversation
Thanks for fixing this. But does this mean that the UMD bundle no longer works? Is there a potential fix for that issue as well? |
@epicfaace I don't know. I haven't used UMD consciously in years if ESM is available. I'd expect if UMD was broken, it'd get raised as an issue otherwise. |
b05be69
to
8ad4065
Compare
Alright, looks like the Tested with a local build and https://gist.github.com/wegry/d17568136713cd9bf697aca624acfe3e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks for finding the fix! :)
packages/core/webpack.config.dist.js
Outdated
@@ -14,6 +15,9 @@ module.exports = { | |||
libraryTarget: "umd" | |||
}, | |||
plugins: [ | |||
new MonacoWebpackPlugin({ | |||
languages: ['json'] | |||
}), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this plugin is usable within a library. I'm almost certain that we're just incurring a build time cost with no usable change in output.
It makes sense for it to be available within the playground and docs though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that's right. Perhaps we could split it so it's only available for the playground and docs in a separate PR though?
Reasons for making this change
The React module's Component property wasn't defined in the 3.0 UMD bundle for some reason in codepen. Use ESM @rjsf/core bundle instead.
fixes #2447
Checklist