Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2474 drop unused monaco editor output from core build #2476

Merged

Conversation

wegry
Copy link
Contributor

@wegry wegry commented Jul 18, 2021

Reasons for making this change

#2474 The monaco editor workers being dumped in core's output doesn't make sense.

A portion of the old output from the core build

Screen Shot 2021-07-18 at 14 04 21

After removing the plugin

Screen Shot 2021-07-18 at 14 05 14

The playground continuing to run as expected

Screen Shot 2021-07-18 at 14 14 18

If this is related to existing tickets, include links to them as well. Use the syntax fixes #[issue number] (ex: fixes #123).

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests
    • I've updated docs if needed
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

Copy link
Member

@epicfaace epicfaace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build is passing! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants