Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fluent-ui: Allow value of 0 in TextWidget #2497

Merged
merged 2 commits into from
Aug 13, 2021

Conversation

pksorensen
Copy link
Contributor

Fixes proper undefined/null check and not falsy check. when value is 0 its changed to "" instead of "0"

Reasons for making this change

[Please describe them here]

If this is related to existing tickets, include links to them as well. Use the syntax fixes #[issue number] (ex: fixes #123).

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests
    • I've updated docs if needed
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

Fixes proper undefined/null check and not falsy check.  when value is 0 its changed to "" instead of "0"
Copy link
Member

@epicfaace epicfaace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, can you add a test?

@pksorensen
Copy link
Contributor Author

I can try, not sure where to start.

@epicfaace epicfaace changed the title Update TextWidget.tsx fluent-ui: Allow value of "0" in TextWidget Aug 13, 2021
@epicfaace epicfaace changed the title fluent-ui: Allow value of "0" in TextWidget fluent-ui: Allow value of 0 in TextWidget Aug 13, 2021
@epicfaace epicfaace merged commit b637603 into rjsf-team:master Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants