Allow to change additionalProperties to falsy values #2540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
epicfaace
approved these changes
Sep 27, 2021
|
Can you update from the latest master code and then add a line to the changelog with a description of the bug fixed as mentioned in (https://github.com/rjsf-team/react-jsonschema-form/blob/master/PULL_REQUEST_TEMPLATE.md)? |
|
@epicfaace I've updated changelog and PR description. Thank you for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
fixes #2462
Changing of additionalProperties to any falsy value (false, 0, null) leads to its unexpected conversion to an empty string.
Similar change is proposed here - #2463, but it requires tests and the PR has been stall for a little while. Feel free to cancel current PR, if the other one gets finished faster.
Checklist