Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add event bubbling to submit event (fix for React 17 and up) #2556

Closed

Conversation

elad-ivanir
Copy link

@elad-ivanir elad-ivanir commented Sep 18, 2021

Reasons for making this change

Programmatic submittng does not work for React 17+, due to changes in event delegation in React 17.
I made sure my fix works for earlier versions of React too.

linked issue - #2551

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests
    • I've updated docs if needed
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

@mucluck
Copy link

mucluck commented Oct 13, 2021

@epicfaace this change will be merged?

@epicfaace
Copy link
Member

Thanks for the PR. I'm going to close this for now -- see #2104 (comment) -- we need someone to look into what is the root cause of the issue before we can accept a fix. Not sure if bubbles: true is the right fix that gets to the root of the problem.

@epicfaace epicfaace closed this Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants