Build all packages with TypeScript, including core #2799

nickgros · 2022-04-09T21:58:28Z

Reasons for making this change

Reduce risk of bugs and improve ability to reason with the logic in this library using types

Checklist

I'm updating documentation
- I've checked the rendering of the Markdown text I've added
I'm adding or updating code
- I've added and/or updated tests
- I've updated docs if needed
- I've updated the changelog with a description of the PR
I'm adding a new feature
- I've updated the playground with an example use of the feature

nickgros · 2022-04-15T14:07:49Z

Note--should configure build scripts as in #2810 to ensure we output UMD builds

…a-form into typescript/core

epicfaace

Let's add registry={registry} here:

react-jsonschema-form/packages/antd/src/templates/ArrayFieldTemplate/index.js

Lines 53 to 68 in 75d83a4

    
           <Widget 
        
             autofocus={autofocus} 
        
             disabled={disabled} 
        
             formContext={formContext} 
        
             id={idSchema && idSchema.$id} 
        
             multiple 
        
             onBlur={onBlur} 
        
             onChange={onChange} 
        
             onFocus={onFocus} 
        
             options={options} 
        
             rawErrors={rawErrors} 
        
             readonly={readonly} 
        
             schema={schema} 
        
             title={schema.title || name} // Why not props.title? 
        
             value={formData} 
        
           />

…ogic/react-jsonschema-form into typescript/core

…a-form into typescript/core

packages/antd/tsconfig.json

nickgros · 2022-05-06T15:17:54Z

packages/fluent-ui/src/Theme/Theme.ts

-import React from 'react';
 import ArrayFieldTemplate from '../ArrayFieldTemplate';
 import ErrorList from '../ErrorList';
 import Fields from '../Fields';
 import FieldTemplate from '../FieldTemplate';
 import ObjectFieldTemplate from '../ObjectFieldTemplate';
-import SubmitButton from '../SubmitButton';


Unused imports

packages/fluent-ui/src/SelectWidget/SelectWidget.tsx

packages/fluent-ui/src/RangeWidget/RangeWidget.tsx

heath-freenome · 2022-05-06T15:03:09Z

packages/bootstrap-4/tsconfig.json

  }
-}
+}


Maybe add the missing newline at the end of the file?

packages/fluent-ui/src/DateWidget/DateWidget.tsx

packages/fluent-ui/src/ColorWidget/ColorWidget.tsx

packages/bootstrap-4/tsconfig.json

packages/core/jest.config.js

packages/semantic-ui/tsconfig.json

tsconfig.base.json

nickgros · 2022-05-06T15:17:54Z

packages/fluent-ui/src/Theme/Theme.ts

-import React from 'react';
 import ArrayFieldTemplate from '../ArrayFieldTemplate';
 import ErrorList from '../ErrorList';
 import Fields from '../Fields';
 import FieldTemplate from '../FieldTemplate';
 import ObjectFieldTemplate from '../ObjectFieldTemplate';
-import SubmitButton from '../SubmitButton';


Unused imports

Co-authored-by: Heath C <51679588+heath-freenome@users.noreply.github.com>

tsconfig.base.json

packages/semantic-ui/tsconfig.json

Co-authored-by: Heath C <51679588+heath-freenome@users.noreply.github.com>

packages/chakra-ui/tsconfig.json

Co-authored-by: Heath C <51679588+heath-freenome@users.noreply.github.com>

…a-form into typescript/core

lpillonel · 2022-05-07T15:24:05Z

Since this commit, I am facing some issues regarding tests (at least) :

Tests are failing on core when we trigger them with lerna run test, even if it says the contrary (see below)
Tests can't be executed directly in packages/core as tsdx is not a dependency in core's package.json

@rjsf/core:   console.error
@rjsf/core:     Error: Uncaught [Error: Could not find a definition for #/definitions/nonexistent.]
@rjsf/core:         at reportException (/Users/luca/imtf/react-jsonschema-form/node_modules/jsdom/lib/jsdom/living/helpers/runtime-script-errors.js:62:24)
@rjsf/core:         at innerInvokeEventListeners (/Users/luca/imtf/react-jsonschema-form/node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:332:9)
@rjsf/core:         at invokeEventListeners (/Users/luca/imtf/react-jsonschema-form/node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:267:3)
@rjsf/core:         at HTMLUnknownElementImpl._dispatch (/Users/luca/imtf/react-jsonschema-form/node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:214:9)
@rjsf/core:         at HTMLUnknownElementImpl.dispatchEvent (/Users/luca/imtf/react-jsonschema-form/node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:87:17)
@rjsf/core:         at HTMLUnknownElement.dispatchEvent (/Users/luca/imtf/react-jsonschema-form/node_modules/jsdom/lib/jsdom/living/generated/EventTarget.js:144:23)
@rjsf/core:         at Object.invokeGuardedCallbackDev (/Users/luca/imtf/react-jsonschema-form/packages/core/node_modules/react-dom/cjs/react-dom.development.js:397:16)
@rjsf/core:         at invokeGuardedCallback (/Users/luca/imtf/react-jsonschema-form/packages/core/node_modules/react-dom/cjs/react-dom.development.js:454:31)
@rjsf/core:         at beginWork$$1 (/Users/luca/imtf/react-jsonschema-form/packages/core/node_modules/react-dom/cjs/react-dom.development.js:23217:7)
@rjsf/core:         at performUnitOfWork (/Users/luca/imtf/react-jsonschema-form/packages/core/node_modules/react-dom/cjs/react-dom.development.js:22211:12) Error: Could not find a definition for #/definitions/nonexistent.
.......
@rjsf/core:   console.warn
@rjsf/core:     Using autocomplete property of Form is deprecated, use autoComplete instead.
@rjsf/core:       470 |     const SubmitButton = registry.widgets.SubmitButton;
@rjsf/core:       471 |     if (deprecatedAutocomplete) {
@rjsf/core:     > 472 |       console.warn(
@rjsf/core:           |               ^
@rjsf/core:       473 |         "Using autocomplete property of Form is deprecated, use autoComplete instead."
@rjsf/core:       474 |       );
@rjsf/core:       475 |     }
@rjsf/core:       at Form.render (src/components/Form.js:472:15)
@rjsf/core:       at finishClassComponent (node_modules/react-dom/cjs/react-dom.development.js:17039:31)
@rjsf/core:       at updateClassComponent (node_modules/react-dom/cjs/react-dom.development.js:16994:24)
@rjsf/core:       at beginWork$1 (node_modules/react-dom/cjs/react-dom.development.js:18505:16)
@rjsf/core:       at beginWork$$1 (node_modules/react-dom/cjs/react-dom.development.js:23193:14)
@rjsf/core:       at performUnitOfWork (node_modules/react-dom/cjs/react-dom.development.js:22211:12)
@rjsf/core:       at workLoopSync (node_modules/react-dom/cjs/react-dom.development.js:22185:22)
@rjsf/core:   console.warn
@rjsf/core:     unknown format "area-code" ignored in schema at path "#/properties/areaCode"
@rjsf/core:       at Object.generate_format [as code] (node_modules/ajv/lib/dotjs/format.js:58:19)
@rjsf/core:       at Object.generate_validate [as validate] (node_modules/ajv/lib/dotjs/validate.js:382:35)
@rjsf/core:       at Object.generate_properties [as code] (node_modules/ajv/lib/dotjs/properties.js:201:26)
@rjsf/core:       at generate_validate (node_modules/ajv/lib/dotjs/validate.js:382:35)
@rjsf/core:       at localCompile (node_modules/ajv/lib/compile/index.js:88:22)
@rjsf/core:       at Ajv.compile (node_modules/ajv/lib/compile/index.js:55:13)
@rjsf/core:       at Ajv._compile (node_modules/ajv/lib/ajv.js:348:27)
@rjsf/core:   console.warn
@rjsf/core:     unknown format "area-code" ignored in schema at path "#/properties/areaCode"
@rjsf/core:       at Object.generate_format [as code] (node_modules/ajv/lib/dotjs/format.js:58:19)
@rjsf/core:       at Object.generate_validate [as validate] (node_modules/ajv/lib/dotjs/validate.js:382:35)
@rjsf/core:       at Object.generate_properties [as code] (node_modules/ajv/lib/dotjs/properties.js:201:26)
@rjsf/core:       at generate_validate (node_modules/ajv/lib/dotjs/validate.js:382:35)
@rjsf/core:       at localCompile (node_modules/ajv/lib/compile/index.js:88:22)
@rjsf/core:       at Ajv.compile (node_modules/ajv/lib/compile/index.js:55:13)
@rjsf/core:       at Ajv._compile (node_modules/ajv/lib/ajv.js:348:27)
@rjsf/bootstrap-4: > @rjsf/bootstrap-4@4.2.0 test /Users/luca/imtf/react-jsonschema-form/packages/bootstrap-4
@rjsf/bootstrap-4: > tsdx test
.......
lerna success run Ran npm script 'test' in 7 packages in 72.0s:
lerna success - @rjsf/antd
lerna success - @rjsf/bootstrap-4
lerna success - @rjsf/chakra-ui
lerna success - @rjsf/core
lerna success - @rjsf/fluent-ui
lerna success - @rjsf/material-ui
lerna success - @rjsf/semantic-ui

@epicfaace : are these already known issues ?

lpillonel · 2022-05-07T15:24:15Z

Since this commit, I am facing some issues regarding tests (at least) :

Tests are failing on core when we trigger them with lerna run test, even if it says the contrary (see below)
Tests can't be executed directly in packages/core as tsdx is not a dependency in core's package.json

@rjsf/core:   console.error
@rjsf/core:     Error: Uncaught [Error: Could not find a definition for #/definitions/nonexistent.]
@rjsf/core:         at reportException (/Users/luca/imtf/react-jsonschema-form/node_modules/jsdom/lib/jsdom/living/helpers/runtime-script-errors.js:62:24)
@rjsf/core:         at innerInvokeEventListeners (/Users/luca/imtf/react-jsonschema-form/node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:332:9)
@rjsf/core:         at invokeEventListeners (/Users/luca/imtf/react-jsonschema-form/node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:267:3)
@rjsf/core:         at HTMLUnknownElementImpl._dispatch (/Users/luca/imtf/react-jsonschema-form/node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:214:9)
@rjsf/core:         at HTMLUnknownElementImpl.dispatchEvent (/Users/luca/imtf/react-jsonschema-form/node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:87:17)
@rjsf/core:         at HTMLUnknownElement.dispatchEvent (/Users/luca/imtf/react-jsonschema-form/node_modules/jsdom/lib/jsdom/living/generated/EventTarget.js:144:23)
@rjsf/core:         at Object.invokeGuardedCallbackDev (/Users/luca/imtf/react-jsonschema-form/packages/core/node_modules/react-dom/cjs/react-dom.development.js:397:16)
@rjsf/core:         at invokeGuardedCallback (/Users/luca/imtf/react-jsonschema-form/packages/core/node_modules/react-dom/cjs/react-dom.development.js:454:31)
@rjsf/core:         at beginWork$$1 (/Users/luca/imtf/react-jsonschema-form/packages/core/node_modules/react-dom/cjs/react-dom.development.js:23217:7)
@rjsf/core:         at performUnitOfWork (/Users/luca/imtf/react-jsonschema-form/packages/core/node_modules/react-dom/cjs/react-dom.development.js:22211:12) Error: Could not find a definition for #/definitions/nonexistent.
.......
@rjsf/core:   console.warn
@rjsf/core:     Using autocomplete property of Form is deprecated, use autoComplete instead.
@rjsf/core:       470 |     const SubmitButton = registry.widgets.SubmitButton;
@rjsf/core:       471 |     if (deprecatedAutocomplete) {
@rjsf/core:     > 472 |       console.warn(
@rjsf/core:           |               ^
@rjsf/core:       473 |         "Using autocomplete property of Form is deprecated, use autoComplete instead."
@rjsf/core:       474 |       );
@rjsf/core:       475 |     }
@rjsf/core:       at Form.render (src/components/Form.js:472:15)
@rjsf/core:       at finishClassComponent (node_modules/react-dom/cjs/react-dom.development.js:17039:31)
@rjsf/core:       at updateClassComponent (node_modules/react-dom/cjs/react-dom.development.js:16994:24)
@rjsf/core:       at beginWork$1 (node_modules/react-dom/cjs/react-dom.development.js:18505:16)
@rjsf/core:       at beginWork$$1 (node_modules/react-dom/cjs/react-dom.development.js:23193:14)
@rjsf/core:       at performUnitOfWork (node_modules/react-dom/cjs/react-dom.development.js:22211:12)
@rjsf/core:       at workLoopSync (node_modules/react-dom/cjs/react-dom.development.js:22185:22)
@rjsf/core:   console.warn
@rjsf/core:     unknown format "area-code" ignored in schema at path "#/properties/areaCode"
@rjsf/core:       at Object.generate_format [as code] (node_modules/ajv/lib/dotjs/format.js:58:19)
@rjsf/core:       at Object.generate_validate [as validate] (node_modules/ajv/lib/dotjs/validate.js:382:35)
@rjsf/core:       at Object.generate_properties [as code] (node_modules/ajv/lib/dotjs/properties.js:201:26)
@rjsf/core:       at generate_validate (node_modules/ajv/lib/dotjs/validate.js:382:35)
@rjsf/core:       at localCompile (node_modules/ajv/lib/compile/index.js:88:22)
@rjsf/core:       at Ajv.compile (node_modules/ajv/lib/compile/index.js:55:13)
@rjsf/core:       at Ajv._compile (node_modules/ajv/lib/ajv.js:348:27)
@rjsf/core:   console.warn
@rjsf/core:     unknown format "area-code" ignored in schema at path "#/properties/areaCode"
@rjsf/core:       at Object.generate_format [as code] (node_modules/ajv/lib/dotjs/format.js:58:19)
@rjsf/core:       at Object.generate_validate [as validate] (node_modules/ajv/lib/dotjs/validate.js:382:35)
@rjsf/core:       at Object.generate_properties [as code] (node_modules/ajv/lib/dotjs/properties.js:201:26)
@rjsf/core:       at generate_validate (node_modules/ajv/lib/dotjs/validate.js:382:35)
@rjsf/core:       at localCompile (node_modules/ajv/lib/compile/index.js:88:22)
@rjsf/core:       at Ajv.compile (node_modules/ajv/lib/compile/index.js:55:13)
@rjsf/core:       at Ajv._compile (node_modules/ajv/lib/ajv.js:348:27)
@rjsf/bootstrap-4: > @rjsf/bootstrap-4@4.2.0 test /Users/luca/imtf/react-jsonschema-form/packages/bootstrap-4
@rjsf/bootstrap-4: > tsdx test
.......
lerna success run Ran npm script 'test' in 7 packages in 72.0s:
lerna success - @rjsf/antd
lerna success - @rjsf/bootstrap-4
lerna success - @rjsf/chakra-ui
lerna success - @rjsf/core
lerna success - @rjsf/fluent-ui
lerna success - @rjsf/material-ui
lerna success - @rjsf/semantic-ui

@epicfaace : are these already known issues ?

epicfaace · 2022-05-16T19:15:02Z

Not sure, can you open an issue? It's working on CI.

…#2799)" This reverts commit 724fb0b.

nickgros added 10 commits April 9, 2022 21:54

Build all packages with tsdx

b133f8b

Drop eslint ecmaFeatures

05ee8ef

Disable new lint rules for now

fb35afa

Utils has not changed

36150db

Drop unused imports/variables

c0a9602

Drop unused import

cb1a24c

Fix build issues-mostly unused props/imports

03a4406

Factor out typescript devDependencies

b1d4958

Remove unnecessary target override

a50fe12

Bump fluentui to v8 for compatibility w/ react 17+

9b8dfc5

jacqueswho added enhancement core labels Apr 11, 2022

stringfellow and others added 4 commits April 12, 2022 14:33

provide tsdx build format arg to build UMD

d223cd0

Newer version of react-is is causing failure for some reason

3bddf3e

Move getDefaultRegistry to prevent dependency cycle

3f9088e

Don't default to the default registry (breaks dependency cycle)

fbd6782

nickgros added 2 commits April 15, 2022 14:13

Merge branch 'master' of https://github.com/rjsf-team/react-jsonschem…

3419a24

…a-form into typescript/core

Drop unused imports in fluent-ui Theme.ts

75d83a4

epicfaace reviewed Apr 15, 2022

View reviewed changes

epicfaace mentioned this pull request Apr 15, 2022

Circular Dependencies in @rjsf\core when using Rollup #2341

Closed

3 tasks

nickgros added 6 commits April 19, 2022 01:02

Merge branch 'themes/tsdx-buildout-umd' of https://github.com/DemandL…

e642b82

…ogic/react-jsonschema-form into typescript/core

Include output to UMD in other packages

64f5d40

Ensure registry is being passed

7b64313

Use ts-loader and continue to use webpack for core

4aee251

Merge branch 'master' of https://github.com/rjsf-team/react-jsonschem…

f83a328

…a-form into typescript/core

Build all package types in one go

5618fb0

nickgros marked this pull request as ready for review May 3, 2022 21:22

Merge branch 'master' into typescript/core

eefce62

heath-freenome reviewed May 6, 2022

View reviewed changes