Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add nx to monorepo #2984

Closed
wants to merge 6 commits into from
Closed

chore: add nx to monorepo #2984

wants to merge 6 commits into from

Conversation

ahkhanjani
Copy link
Contributor

@ahkhanjani ahkhanjani commented Aug 3, 2022

The first step of transitioning from Lerna to Nx. This currently doesn't have a breaking effect. To use Nx tools in vscode install "Nx Console" extension.

@heath-freenome
Copy link
Member

@ahkhanjani It looks like you'll need to make some changes to fix the build

@ahkhanjani
Copy link
Contributor Author

Seems like for some reason npm messed up the lock-files. I'll make another commit

@heath-freenome
Copy link
Member

@ahkhanjani A previous commit is actually breaking the build. I am about to merge a PR with the fix for it. You may have to wait a few hours and do a rebase.

@ahkhanjani
Copy link
Contributor Author

Thanks for telling. I will try to fix some issues on my side as well. Please consider reading this document for the free cloud caching by Nx. This is going to be added with this PR being merged and will speed up the build process.

@heath-freenome
Copy link
Member

heath-freenome commented Aug 5, 2022

@ahkhanjani did you want to join our weekly meeting on August 5th at 11am Eastern Time (see #2417 for details) to walk us through your PR and where you see things going?

@ahkhanjani
Copy link
Contributor Author

@ahkhanjani did you want to join our weekly meeting on August 5th at 11am Eastern Time (see #2417 for details) to walk us through your PR and where you see things going?

I'm afraid my time zone doesn't let me. But I can provide a written documentation and milestone.

"build:dist",
"publish-to-gh-pages"
],
"accessToken": "N2UzOTU5MGQtMmM1OS00MTM2LWJjM2QtZDZhM2IxOWYzM2RkfHJlYWQtd3JpdGU="
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a secret that needs to be passed in as a variable? I'm not sure we want to use the cloud... and if we did, we really don't want this secret sitting in a public file (we have a place for them). Can we not use the cloud services by default?

@heath-freenome
Copy link
Member

@ahkhanjani did you want to join our weekly meeting on August 5th at 11am Eastern Time (see #2417 for details) to walk us through your PR and where you see things going?

I'm afraid my time zone doesn't let me. But I can provide a written documentation and milestone.

That would be great!

@ahkhanjani ahkhanjani requested review from heath-freenome and removed request for epicfaace August 5, 2022 16:41
@heath-freenome
Copy link
Member

@ahkhanjani Looks like you have conflicts... Rebase onto the latest and when you resolve the SubmitButton take the one from the rjsf-v5 branch as it is. Probably the same for the package-lock.json files as well.

@ahkhanjani
Copy link
Contributor Author

I will create a new pr as the current rebase ended up in a mess.

@ahkhanjani ahkhanjani closed this Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants