Change boolean custom tag to bsPrefix. #3049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillowP
commented
Aug 26, 2022
| @@ -82,7 +82,7 @@ const SelectWidget = ({ | |||
| </Form.Label> | |||
| <Form.Control | |||
| as="select" | |||
| custom | |||
| bsPrefix="custom-select" | |||
There was a problem hiding this comment.
When I just removed custom, the tests failed because the className changed from custom-select to form-control. The bsPrefix prop seems to be the way to approach this, based on the docs at https://react-bootstrap.github.io/forms/form-control/#form-control-props
There was a problem hiding this comment.
Two things... First, it would be better to put this change into the upcoming rjsf-v5 beta branch, so can you please rebase and do it there? Second, please reference the issue you are fixing in the CHANGELOG.md.
heath-freenome
approved these changes
Sep 8, 2022
heath-freenome
added a commit
to heath-freenome/react-jsonschema-form
that referenced
this pull request
Sep 8, 2022
…roper location
heath-freenome
added a commit
that referenced
this pull request
Sep 8, 2022
* Reimplemented fix in #2198 in @rjsf/utils package - The fix in #2198 needed to be refactored into the new `@rjsf/utils` package - Replicated the fix into the `getDefaultFormState.ts` file - Replicated the additional tests into `getDefaultFormStateTest.ts` and `oneOf_test.js` - Updated the `CHANGELOG.md` with the note for this fix along with the notes for PR #3094 * - Updated `CHANGELOG.md` for PR #2925 * - Fixed up `CHANGELOG.md` to move note from #3049 into the proper location
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
fixes #2648
Checklist
npm run test:updateto update snapshots, if needed.