Get semantic-ui theme on react 17 and dts-cli #3083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated the `package*.json` to update to react 17 and switch from `tsdx` to `dts-cli` - Updated the tests to mock the `Ref` component from `@fluentui/react-component-ref` because it causes tests to fail
…t uses a newer version of `prettier`
heath-freenome
force-pushed
the
fix-semantic-ui-to-use-dts-cli
branch
from
8b5ba6a
to
b685c47
Compare
jacqueswho
approved these changes
Sep 3, 2022
| @@ -4,6 +4,12 @@ import renderer from "react-test-renderer"; | |||
|
|
|||
| import Form from "../src/index"; | |||
|
|
|||
| /** Mock the `react-component-ref` component used by semantic-ui to simply render the children, otherwise tests fail */ | |||
| jest.mock("@fluentui/react-component-ref", () => ({ | |||
There was a problem hiding this comment.
Should this be semantic-ui
There was a problem hiding this comment.
@jacqueswho Actually, it needs to be @fluentui/react-component-ref... Looking at the semantic-ui-react source code you can see that it is what needs to be mocked
| @@ -4,6 +4,12 @@ import renderer from "react-test-renderer"; | |||
|
|
|||
| import Form from "../src/index"; | |||
|
|
|||
| /** Mock the `react-component-ref` component used by semantic-ui to simply render the children, otherwise tests fail */ | |||
| jest.mock("@fluentui/react-component-ref", () => ({ | |||
There was a problem hiding this comment.
Should this be semantic-ui
| @@ -4,6 +4,12 @@ import renderer from "react-test-renderer"; | |||
|
|
|||
| import Form from "../src/index"; | |||
|
|
|||
| /** Mock the `react-component-ref` component used by semantic-ui to simply render the children, otherwise tests fail */ | |||
| jest.mock("@fluentui/react-component-ref", () => ({ | |||
| ...jest.requireActual("@fluentui/react-component-ref"), | |||
There was a problem hiding this comment.
Should this be semantic-ui
| @@ -4,6 +4,12 @@ import renderer from "react-test-renderer"; | |||
|
|
|||
| import Form from "../src/index"; | |||
|
|
|||
| /** Mock the `react-component-ref` component used by semantic-ui to simply render the children, otherwise tests fail */ | |||
| jest.mock("@fluentui/react-component-ref", () => ({ | |||
There was a problem hiding this comment.
Should this be semantic-ui
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
package*.jsonto update to react 17 and switch fromtsdxtodts-clics-formatoversemantic-uiafter upgrading todts-clithat uses a newer version ofprettierRefcomponent from@fluentui/react-component-refbecause it causes tests to fail5.x migration guideand theCHANGELOG.mdChecklist
npm run test:updateto update snapshots, if needed.