fix: Prevent the Playground from crashing on a form error. #3164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heath-freenome
requested changes
Sep 30, 2022
heath-freenome
changed the title
|
@nickgros Have you verified that this will handle all the uses cases you've indicated will be fixed? |
nickgros
commented
Oct 3, 2022
nickgros
commented
Oct 3, 2022
Co-authored-by: Heath C <51679588+heath-freenome@users.noreply.github.com>
This was
linked to
issues
Oct 3, 2022
Yep, and just added a few more. The Form component is still going to throw an error in user code, but in those cases, users should use an error boundary themselves, or open a new issue/PR and clearly define what the behavior should be. |
This was referenced Oct 3, 2022
heath-freenome
approved these changes
Oct 3, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3132, #3095, #2787, #2277, #2179, #2170, #2163, #1762, and #1002;
Potentially fixes other issues that I couldn't find.