Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: BooleanField component to not alter readOnly props #3188

Merged
merged 3 commits into from
Oct 7, 2022

Conversation

jacqueswho
Copy link
Contributor

Reasons for making this change

Fixed the code for the BooleanField component to not alter the readonly props

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests. I've run npm run test:update to update snapshots, if needed.
    • I've updated docs if needed
    • I've updated the changelog with a description of the PR
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

Copy link
Member

@heath-freenome heath-freenome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the CHANGELOG.md

@jacqueswho
Copy link
Contributor Author

@heath-freenome this has not been reported and mentioned, thought change log is for existing issues

@heath-freenome heath-freenome merged commit 848056e into main Oct 7, 2022
@heath-freenome heath-freenome deleted the fix/core_boolean_field branch October 7, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants