fix: #3260 by properly mapping missing required fields #3309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix rjsf-team#3260 The required field errors weren't mapped to the fields they were associated to in the `ErrorSchema` This mapping issue was fixed as follows: - In `@rjsf/core`, updated the `Form` and `validate` tests to fix the mapping issue in the test data for the required fields - In `@rjsf/validator-ajv6`, added additional tests for testing top-level and nested required field errors to verify things worked with ajv6 - In `@rjsf/validator-ajv8`, fixed the `transformRJSFValidationErrors()` function in the validator to look for `missingProperty: 'field'` information in the `params` property using that to properly map the error `property` - Replicated the tests made in `@rjsf/validator-ajv6` to this package to verify that the fix is working properly - Updated the `CHANGELOG.md` accordingly
nickgros
changed the title
nickgros
approved these changes
Dec 22, 2022
5 tasks
shijistar
pushed a commit
to shijistar/react-jsonschema-form
that referenced
this pull request
Jun 8, 2023
fix rjsf-team#3260 The required field errors weren't mapped to the fields they were associated to in the `ErrorSchema` This mapping issue was fixed as follows: - In `@rjsf/core`, updated the `Form` and `validate` tests to fix the mapping issue in the test data for the required fields - In `@rjsf/validator-ajv6`, added additional tests for testing top-level and nested required field errors to verify things worked with ajv6 - In `@rjsf/validator-ajv8`, fixed the `transformRJSFValidationErrors()` function in the validator to look for `missingProperty: 'field'` information in the `params` property using that to properly map the error `property` - Replicated the tests made in `@rjsf/validator-ajv6` to this package to verify that the fix is working properly - Updated the `CHANGELOG.md` accordingly
shijistar
pushed a commit
to shijistar/react-jsonschema-form
that referenced
this pull request
Jun 8, 2023
fix rjsf-team#3260 The required field errors weren't mapped to the fields they were associated to in the `ErrorSchema` This mapping issue was fixed as follows: - In `@rjsf/core`, updated the `Form` and `validate` tests to fix the mapping issue in the test data for the required fields - In `@rjsf/validator-ajv6`, added additional tests for testing top-level and nested required field errors to verify things worked with ajv6 - In `@rjsf/validator-ajv8`, fixed the `transformRJSFValidationErrors()` function in the validator to look for `missingProperty: 'field'` information in the `params` property using that to properly map the error `property` - Replicated the tests made in `@rjsf/validator-ajv6` to this package to verify that the fix is working properly - Updated the `CHANGELOG.md` accordingly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
fix #3260
The required field errors weren't mapped to the fields they were associated to in the
ErrorSchemaThis mapping issue was fixed as follows:@rjsf/core, updated theFormandvalidatetests to fix the mapping issue in the test data for the required fields@rjsf/validator-ajv6, added additional tests for testing top-level and nested required field errors to verify things worked with ajv6@rjsf/validator-ajv8, fixed thetransformRJSFValidationErrors()function in the validator to look formissingProperty: 'field'information in theparamsproperty using that to properly map the errorproperty@rjsf/validator-ajv6to this package to verify that the fix is working properlyCHANGELOG.mdaccordinglyChecklist
npm run test:updateto update snapshots, if needed.Before:
After:
