Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sanitizeDataForNewSchema.ts #3443

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tmlstevens
Copy link

Reasons for making this change

fixes 3442

@heath-freenome
Copy link
Member

heath-freenome commented Feb 21, 2023

@tmlstevens While this fix may help your issue, it is also possible it will reopen several other, more serious issues (the reason undefined was left in the data structure). Can you verify that the reproducible cases provided in #3236, #2978,
#2944, #2202, #2183 and #2086 all remain working with your PR? Also, You will need to run the npm run cs-format command to correct the linting errors. Finally, please update the CHANGELOG.md file for this change

@heath-freenome
Copy link
Member

@tmlstevens Have you had a chance to look over my feedback?

Copy link

stale bot commented Jun 28, 2024

This issue has been automatically marked as possibly close because it has not had recent activity. It will be closed if no further activity occurs. Please leave a comment if this is still an issue for you. Thank you.

@stale stale bot added the possibly close To confirm if this issue can be closed label Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
possibly close To confirm if this issue can be closed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prev. selected oneOf schema properties removed only IF populated when schema changes
2 participants