Missing prototype in CheckboxesWidget.js #414
Conversation
… instead of empty string or empty array to be consistent with other field types.
…g on fallback validation and consistent with other control that support it. Enable the required field for arrays. Good for where you might want at least one options selected in a checkbox group for example.
…llowing updates. (remove _react)
…come through as a boolean "false". Convert that to an empty array so that the enumOptions.map will not error in the render. The list will temporarily be empty, but better than erroring and never filling.
…llowing updates. (make compatible with recent checkin)
…dget needs updating still). NOTE: Could have converted optionsList to value and label in utils.js however there could be cases where the entire data structure is useful in the widget. I envisage it could possibily be a grid control with many columns with checkboxes on the left ... using something like ag-grid. So a simple value/key pairing may not be enough. Instead extract the value/key data out of the data structure in the widgets themselves. Coopted the enumOptions variable for this purpose, could be a different name. Checking for value/key in "items" child for multi select array. This could be done elsewhere too, but seemed the least invasive.
… instead of empty string or empty array to be consistent with other field types. Fix accidental syntax error ... should be _onChange.
…come through as a boolean "false". Convert that to an empty array so that the enumOptions.map will not error in the render. The list will temporarily be empty, but better than erroring and never filling. Move the fix back to where optionsList is being set to False. A more general fix.
|
OK ... that didn't work the way I wanted .... I only want one of those patches in this PR :( |
|
Also ... that failed auto-test was a syntax error fixed in a later commit. Obviously this system requires each individual commit to be good, rather than the set? Anyway really I just wanted c7a7b4a in this PR. For the life of my though I can't find how to select/deselect the commits I want in my PR ... I'll keep looking and reading. Sorry for the confusion, but I will get better at this! |
|
Hey now worries, things always have to be learned at some point ;) Try to learn about rebasing, this is exactly what you need here; the idea would be to force push your branch rebased with your single commit here. There are a lot of good tutos out there about this! |
|
Thanks Nicholas ... will do! :) |
|
Fixed by #416 |
Reasons for making this change
Missing prototype in CheckboxesWidget.js
Referencing issue:
#413
Checklist