Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onfocus support #657

Merged
merged 5 commits into from
Aug 11, 2017
Merged

Onfocus support #657

merged 5 commits into from
Aug 11, 2017

Conversation

mauriciominella
Copy link
Contributor

Reasons for making this change

I'm currently developing a JSON Based Configuration editor, where I'll have a split screen where the Form and the raw JSON will be displayed side-by-side. One of the requirements is to highlight the correspondent field on the raw JSON split as soon a field is focused on the form. Currently only onBlur event is supported, so, I've added onFocus support.

Checklist

  • I'm updating documentation
    • I've checked the rendering of the Markdown text I've added
    • If I'm adding a new section, I've updated the Table of Content
  • I'm adding or updating code
    • I've added and/or updated tests
    • I've updated docs if needed
    • I've run npm run cs-format on my branch to conform my code to prettier coding style
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

@n1k0
Copy link
Collaborator

n1k0 commented Aug 8, 2017

LGTM. Please just remove the added package-lock.json, we don't want to version this file with this project.

@mauriciominella
Copy link
Contributor Author

@n1k0 Thanks for the heads up. I've just removed the file as requested.

@n1k0 n1k0 merged commit 40fc2fd into rjsf-team:master Aug 11, 2017
@n1k0
Copy link
Collaborator

n1k0 commented Aug 11, 2017

Thanks!

@theengineear
Copy link
Contributor

theengineear commented Aug 18, 2017

@n1k0 I was hoping to use this onFocus support in a project, any chance a new release is slated soon?

[EDIT]: I'm just jamming my onFocus into formContext until this gets released. Works well enough for now :)

@n1k0
Copy link
Collaborator

n1k0 commented Aug 21, 2017

Next release will hopefully happen this week, stay tuned.

@glasserc
Copy link
Contributor

glasserc commented Sep 6, 2017

Released in v0.50.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants