Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass more props to ErrorList #658

Merged
merged 4 commits into from
Aug 7, 2017

Conversation

olzraiti
Copy link
Contributor

@olzraiti olzraiti commented Aug 4, 2017

Reasons for making this change

formContext should be passed to every component that renders something for proper on-the-fly localization, styling etc.

EDIT: I passed also errorSchema, schema and uiSchema since they allow you to create a much more powerful & integrated component (you can pick labels from the schema, styles & root id from uiSchema to create links to the HTML id anchors where the errors are etc).

Checklist

  • I'm updating documentation
    • I've checked the rendering of the Markdown text I've added
    • If I'm adding a new section, I've updated the Table of Content
  • I'm adding or updating code
    • I've added and/or updated tests
    • I've updated docs if needed
    • I've run npm run cs-format on my branch to conform my code to prettier coding style
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

@olzraiti olzraiti changed the title Pass formContext to ErrorList Pass formContext & errorSchema to ErrorList Aug 7, 2017
@olzraiti olzraiti changed the title Pass formContext & errorSchema to ErrorList Pass more props to ErrorList Aug 7, 2017
@n1k0 n1k0 merged commit 1eb5b73 into rjsf-team:master Aug 7, 2017
@n1k0
Copy link
Collaborator

n1k0 commented Aug 7, 2017

Thank you!

@glasserc
Copy link
Contributor

glasserc commented Sep 6, 2017

Released in v0.50.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants