Fix behaviour of arrays with minItems and default #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix bug whereby defaults in an array were munged together and added to extra item's formData. Behaviour now is to fill the array with the object level default array, and then add extra items up to minItems. These extra items will be either empty or the item-level default. Added demonstration of this in the Arrays tab of the playground.
n1k0
approved these changes
Aug 9, 2017
9 tasks
|
Released in v0.50.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
When providing both default (as a list) and minItems to a field of type array
the defaults are treated as a single value that ends up in each field.
This is a repost of PR #655 which got accidentally deleted and automatically closed, and updated to fix conflict with master.
Relates to ticket
#631
Expected behavior
defaults should be treated as a list and be given one entry each, i.e.:
When minItems > default.length provide empty or item-level default fields after the fields with the default values.
When minItems <= default.length provide one field per value in default list.
Actual behavior
The default items gets mashed together into each field
Checklist
npm run cs-formaton my branch to conform my code to prettier coding style