Fix for MIDI RX bug #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -630,7 +630,9 @@ void USB_Flush(u8 ep) | |||
| Serial.accept(); | |||
| #endif | |||
| #ifdef MIDI_ENABLED | |||
| MIDIUSB.accept(); | |||
| USB_Flush(MIDI_TX); | |||
| if (USB_Available(MIDI_RX)) | |||
There was a problem hiding this comment.
Added this to check if there is something to read before calling accept, as CDC code does
|
Thanks - I missed that one, and I haven't properly tested the MIDI receive functionality yet (at the moment I only use it to send MIDI messages from the Arduino to the PC). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MIDIUSB class was trying to receive data from CDC_RX endpoint instead of MIDI_RX endpoint. Probably you forgot to change it when you copied CDC source. :)