Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot read property 'inputBox' of undefined #48

Closed
rkotze opened this issue Nov 10, 2020 · 2 comments
Closed

Cannot read property 'inputBox' of undefined #48

rkotze opened this issue Nov 10, 2020 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@rkotze
Copy link
Owner

rkotze commented Nov 10, 2020

Description

When selecting a co-author an error appears "Cannot read property 'inputBox' of undefined".

This is an issue in the latest release of VS Code 1.51

Related bugs in VS Code logged which might fix the issue

Steps to Reproduce

  1. Click the plus button to select a co-author
  2. Error appears and unselected co-authors disappear

Expected behaviour:

Update SCM input box with the selected co-author, selected co-authors stay and no error alert shows.

Actual behaviour:

The error appears and unselected co-authors disappear.

Reproduces how often:

For one Git repositories 95% of the time.

Multiple repositories, as long as you have one selected the issue does not appear. However, when you click in the input box it becomes unselected and the error appears.

Mitigation

Reloading the whole of VS Code mitigates the issue as long as you don't interact with the SCM at all.

Versions

  • mac OS Catalina
  • git-mob-vs-code version 1.10.0
  • git-mob version 1.1.0
  • git version 2.24.3
@rkotze rkotze self-assigned this Nov 10, 2020
@rkotze rkotze added the bug Something isn't working label Nov 10, 2020
@rkotze rkotze moved this from To do to In progress in Agile board for Git Mob Nov 10, 2020
rkotze added a commit that referenced this issue Nov 10, 2020
To help mitigate single repositories not selected in VS Code Git UI, it's best to fallback to first repo in the list.

#48
rkotze added a commit that referenced this issue Nov 10, 2020
It can still fail to add a co-author for multiple repositories. Put a try catch to ensure the co-author lists don't disappear when the error occurs.

#48
rkotze added a commit that referenced this issue Nov 11, 2020
Link to vs code git mob issues to encourage users to log errors if one pops up.

#48
@rkotze rkotze moved this from In progress to Release ready in Agile board for Git Mob Nov 11, 2020
@rkotze
Copy link
Owner Author

rkotze commented Nov 11, 2020

Successfully deployed 1.10.1

@ORiveraJr84
Copy link

I'm still having this same issue. Has a resolution been found?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

2 participants