-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Toggle sort order command #74
Conversation
@rkotze can you review this PR before October 31 or at least add |
Hi @viperet Just a few things:
I think my issue was not clear on how I imagined this working. I see you have allowed sorting per section 'selected', 'unselected', and 'more authors' but what I would prefer is you would toggle and it would apply to all sections rather than per section. How does that sound too you? Sorry for the confusion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see the previous comment and a couple of unit tests failing to fix.
@rkotze sure, will fix that. Do you prefer parameter in the settings or icon in the sidebar to set sorting order? |
@viperet could you make it a setting, please? |
Yes, sure. I’m on vacation now, will return in a week and change this PR according to your request |
@rkotze I moved sorting direction to extension configuration and fixed tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rkotze done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @viperet
This PR adds the ability to toggle authors' sort order. (#73)