Skip to content
This repository has been archived by the owner on Feb 24, 2020. It is now read-only.

glide: update docker2aci to v0.12.1 #2873

Merged
merged 1 commit into from
Jul 14, 2016

Conversation

iaguis
Copy link
Member

@iaguis iaguis commented Jul 5, 2016

It includes support for the docker image format v2.2 and OCI image
format and allows fetching via digest.

Ref: #2188

To fully fix #2188 it we need to verify signatures (appc/docker2aci#156)

@iaguis iaguis added this to the v1.10.0 milestone Jul 5, 2016
@iaguis iaguis force-pushed the iaguis/bump-docker2aci-v0.12.0 branch from 904cb81 to 01dfb2b Compare July 6, 2016 16:01
@iaguis
Copy link
Member Author

iaguis commented Jul 6, 2016

Rebased

@jonboulle
Copy link
Contributor

Waiting on more tests to decide whether this lands in v1.10.0 /cc @dgonyeo

@cgonyeo
Copy link
Member

cgonyeo commented Jul 6, 2016

Won't have the docker2aci tests ready by tomorrow, so I vote let's just hold off on bumping docker2aci until I can finish those.

@iaguis
Copy link
Member Author

iaguis commented Jul 7, 2016

Alright then.

@iaguis iaguis modified the milestones: v1.11.0, v1.10.0 Jul 7, 2016
@cgonyeo
Copy link
Member

cgonyeo commented Jul 11, 2016

Cross linking: this is the PR that has some tests: appc/docker2aci#181

It doesn't test all of the different things docker2aci supports, but it at least tests some of the new functionality.

@iaguis
Copy link
Member Author

iaguis commented Jul 13, 2016

I think we can merge this now, right?

@cgonyeo
Copy link
Member

cgonyeo commented Jul 13, 2016

There was one or two tweaks I made to docker2aci as a result of the tests I added, so I think it'd be safer to cut another release of docker2aci after the tests PR is merged and bump it here to that.

@iaguis
Copy link
Member Author

iaguis commented Jul 13, 2016

Right, forgot about that...
On Jul 13, 2016 20:44, "Derek Gonyeo" notifications@github.com wrote:

There was one or two tweaks I made to docker2aci as a result of the tests
I added, so I think it'd be safer to cut another release of docker2aci
after the tests PR is merged and bump it here to that.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#2873 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAe92jQaANyOBIGREuDCghtGrQWb8drBks5qVTIcgaJpZM4JFSsh
.

@iaguis iaguis force-pushed the iaguis/bump-docker2aci-v0.12.0 branch from 01dfb2b to ded2f7c Compare July 14, 2016 10:45
It includes support for the docker image format v2.2 and OCI image
format and allows fetching via digest.
@iaguis iaguis changed the title glide: update docker2aci to v0.12.0 glide: update docker2aci to v0.12.1 Jul 14, 2016
@iaguis iaguis force-pushed the iaguis/bump-docker2aci-v0.12.0 branch from ded2f7c to 12bed38 Compare July 14, 2016 10:46
@iaguis
Copy link
Member Author

iaguis commented Jul 14, 2016

Updated to v0.12.1

@lucab
Copy link
Member

lucab commented Jul 14, 2016

LGTM

@iaguis iaguis merged commit 4b7f4a4 into rkt:master Jul 14, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

verify and run docker images by hash ID
4 participants