Skip to content
This repository has been archived by the owner on Feb 24, 2020. It is now read-only.

Bump appc/docker2aci library version to 0.15.0 #3534

Merged
merged 1 commit into from
Jan 17, 2017
Merged

Bump appc/docker2aci library version to 0.15.0 #3534

merged 1 commit into from
Jan 17, 2017

Conversation

ybubnov
Copy link
Contributor

@ybubnov ybubnov commented Jan 16, 2017

This patch bumps the version of the appc/docker2aci library to 0.15.0
in order to support the conversion of the images with various os/arch.

fixes #3526

This patch bumps the version of the appc/docker2aci library to 0.15.0
in order to support the conversion of the images with various os/arch.
@ghost
Copy link

ghost commented Jan 16, 2017

Can one of the admins verify this patch?

@ybubnov
Copy link
Contributor Author

ybubnov commented Jan 16, 2017

The output of the command, used to download the ubuntu image for aarch64:

$ sudo ./build-rkt-1.22.0+git/target/bin/rkt --debug --insecure-options=image fetch docker://aarch64/ubuntu:latest
image: remote fetching from URL "docker://aarch64/ubuntu:latest"
image: fetching image from docker://aarch64/ubuntu:latest
Downloading sha256:1f8c28d8b7a [=============================]     859 B / 859 B
Downloading sha256:7e21759f0cb [=============================]     169 B / 169 B
Downloading sha256:9dbf9f34817 [=============================]     467 B / 467 B
Downloading sha256:8944e166ce9 [=============================] 46.4 MB / 46.4 MB
Downloading sha256:5cb9db57901 [=============================]     684 B / 684 B
sha512-8fcbbea543851539105f05f7c73a4adf

@lucab
Copy link
Member

lucab commented Jan 16, 2017

ok to test

@glevand
Copy link
Contributor

glevand commented Jan 17, 2017

I tested this and it seems to fix #3526 (fetch: arch messed up).

$ sudo ./rkt --debug --insecure-options=image fetch docker://aarch64/busybox:latest
image: remote fetching from URL "docker://aarch64/busybox:latest"
image: fetching image from docker://aarch64/busybox:latest
Downloading sha256:8df7d836248 [=============================] 1.77 MB / 1.77 MB
sha512-5489fe0c84402cd7d843c35197066adb
$ sudo ./rkt image list 
ID                      NAME                                            SIZE    IMPORT TIME     LAST USED
sha512-5489fe0c8440     registry-1.docker.io/aarch64/busybox:latest     6.6MiB  4 seconds ago   3 seconds ago

@s-urbaniak s-urbaniak added this to the v1.23.0 milestone Jan 17, 2017
Copy link
Contributor

@s-urbaniak s-urbaniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the fedora 24 failure is a known flake

@lucab
Copy link
Member

lucab commented Jan 17, 2017

Great, right in time for 1.23.0! Merging.

@lucab lucab merged commit 9a4483b into rkt:master Jan 17, 2017
@ybubnov ybubnov deleted the bump-appc-docker2aci-version-to-0.15.0 branch January 17, 2017 12:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fetch: arch messed up
4 participants