appc: Fix errno check #3788
appc: Fix errno check #3788
Conversation
There was a problem hiding this comment.
Thanks!
Since it is updating the vendor directory, glide.yaml should be updated accordingly. See:
https://github.com/rkt/rkt/blob/master/Documentation/hacking.md#managing-dependencies
Usually we prefer to vendor released versions.
|
@alban Sorry, I don't quite understand what you would like. My appc patch hasn't yet been merged upstream, and I can't see how to get glide to work with a local patch to rkt's vendor directory. |
|
@glevand sorry I was unclear. I meant we should wait until a new release of appc/spec with the fix before merging this PR. |
|
I've left a comment on the appc PR. Once that is merged, we'll take care of pushing a tag there so we can unblock this. |
errno must start with an 'E' character, and can also contain numeric characters. Fixup the errno check for these. Also, improve the error message by printing the offending errno value. Signed-off-by: Geoff Levand <geoff@infradead.org>
|
We forgot to cross-reference here, this should be superseded by #3803. |
|
Closed via #3803. |
errno symbols can contain numeric characters.
This is a rebased patch I submitted upstream: appc/spec#692 (linuxSeccompBase: Fix errno check).