Skip to content
This repository has been archived by the owner on Feb 24, 2020. It is now read-only.

vendor: bump appc/spec to v0.8.11 #3803

Merged
merged 2 commits into from Sep 20, 2017
Merged

vendor: bump appc/spec to v0.8.11 #3803

merged 2 commits into from Sep 20, 2017

Conversation

squeed
Copy link
Contributor

@squeed squeed commented Sep 19, 2017

No description provided.

@squeed squeed requested a review from lucab September 19, 2017 10:33
@alban
Copy link
Member

alban commented Sep 19, 2017

	rkt_tests.go:117: Spawning command: /home/runner/rkt/builds/build-rkt-coreos/build-rkt-1.28.1+git/tmp/functional/rkt --dir=/tmp/datadir-026539693 --local-config=/tmp/localdir-257755688 --system-config=/tmp/systemdir-545940327 --user-config=/tmp/userdir-695749530 prepare --volume=test,kind=host,source=/tmp/rkt-tests-volume-data283790287 --mount volume=test,target=/mnt --volume=test,kind=empty --mount volume=test,target=/mnt/dup sha512-fabcdf4ec6781360ec343588ca1d49a2
	rkt_tests.go:359: Error: ExpectRegex didn't find regex '[0-9a-f-]{36}'.
		Output: prepare: disabling overlay support: "overlay entry not present in /proc/filesystems"

		prepare: error setting up stage0: json: error calling MarshalJSON for type schema.PodManifest: duplicate volume name "test"

	rkt_tests.go:139: rkt terminated with unexpected status 254, expected 0
		Output:
		[]

Could it be related to appc/spec@0737776?

@lucab
Copy link
Member

lucab commented Sep 19, 2017

@alban the failing test needs a small update, I'm on it.

This skips the run-prepared test if we already know prepare will
fail earlier.
@lucab
Copy link
Member

lucab commented Sep 20, 2017

@alban @iaguis this should be fine now, PTAL.

@squeed
Copy link
Contributor Author

squeed commented Sep 20, 2017

Luca's changes LGTM...

@lucab lucab mentioned this pull request Sep 20, 2017
@lucab lucab requested review from alban and iaguis and removed request for lucab September 20, 2017 10:02
Copy link
Member

@iaguis iaguis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@iaguis iaguis merged commit 9fb7edb into rkt:master Sep 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants