This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
cas: Introduce latest pattern handling for image fetching. #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 19, 2015
sgotti
force-pushed
the
latestpattern
branch
2 times, most recently
from
86736db
to
327efaf
Compare
sgotti
force-pushed
the
latestpattern
branch
2 times, most recently
from
08ff6d0
to
8a1b95b
Compare
|
Please rebase |
sgotti
force-pushed
the
latestpattern
branch
from
8a1b95b
to
28f977b
Compare
|
@iaguis Done! |
|
LGTM |
3 tasks
|
I'm good with this. @philips can you ack the latest behaviour is in line with your expectations too? |
|
Thanks for your review. I'm very interested to know if the behavior is good. This is also referenced in appc/spec#73. |
sgotti
force-pushed
the
latestpattern
branch
2 times, most recently
from
38b94cc
to
d37eb83
Compare
|
@sgotti sorry, we have a conflict now - can you please rebase and I'll get this merged? thanks! |
On fetching, if downloaded with the "latest" pattern (no version label specified), the ACI is saved in the store with the "latest" flag. In future, on "rkt fetch" or "rkt run", a way for the user to define if the provided images (by local file or URL) should be saved in the store with the lastest flag, should be provided. For doing this there's the need to find how the user can request this for a specific file/URL as multiple files/URls can be provided.
|
@jonboulle Done! |
| return fetchImageFromEndpoints(ep, ds, ks) | ||
| latest := false | ||
| // No specified version label, mark it as latest | ||
| if _, ok := app.Labels["version"]; !ok { |
There was a problem hiding this comment.
just realised that _, latest := app.Labels["version"] is a bit simpler
There was a problem hiding this comment.
@jonboulle mmm. it should be negated. something like this?
_, ok := app.Labels["version"]
latest := !ok
There was a problem hiding this comment.
yeah never mind :| needs sleep
|
lgtm |
jonboulle
added a commit
that referenced
this pull request
Mar 12, 2015
cas: Introduce latest pattern handling for image fetching.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last commit is the interesting one. It's based on #393.
On fetching, if downloaded with the "latest" pattern (no version label
specified), the ACI is saved in the store with the "latest" flag.
In future, on "rkt fetch" or "rkt run", a way for the user to define if the
provided images (by local file or URL) should be saved in the store with the
lastest flag, should be provided. For doing this there's the need to find how
the user can request this for a specific file/URL as multiple files/URls can be
provided.
See appc/spec#73 for my thoughts about the need of the "latest" flag.