This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
cas: add a GetACI function. #395
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 19, 2015
sgotti
force-pushed
the
getacidb
branch
2 times, most recently
from
453b104
to
1ba58ae
Compare
This was referenced Jan 28, 2015
sgotti
force-pushed
the
getacidb
branch
2 times, most recently
from
d5345b2
to
2b97fe8
Compare
|
Last commit LGTM |
3 tasks
|
LGTM after #394 lands |
sgotti
force-pushed
the
getacidb
branch
2 times, most recently
from
6ad66c9
to
4d364b7
Compare
On fetching, if downloaded with the "latest" pattern (no version label specified), the ACI is saved in the store with the "latest" flag. In future, on "rkt fetch" or "rkt run", a way for the user to define if the provided images (by local file or URL) should be saved in the store with the lastest flag, should be provided. For doing this there's the need to find how the user can request this for a specific file/URL as multiple files/URls can be provided.
GetACI returns the best ACI that matches the required app name and the provided labels. If there are multiple matching ACIs choose the last one imported in the store. If no version label is requested, ACIs marked as latest in the ACIInfo are preferred.
|
To save time I am going to pull this commit down and merge it |
|
Merged in #625 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last commit is the interesting one. It's based on #394.
GetACI returns the best ACI that matches the required app name and the provided
labels.
If there are multiple matching ACIs choose the latest one (defined as the
last one imported in the store).
If no version label is requested, ACIs marked as latest in the ACIInfo are
preferred.