-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create benchmark test for grid + battery #302
Conversation
@@ -0,0 +1,15 @@ | |||
,unit,storage capacity,input power,output power |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smartie2076 - does it correspond to the 1MWh capacity battery described in the benchmark test A+E #106 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes: Cell installedCap
/storage capacity
has to be defined as 1000 - which it already is.
@smartie2076 - I was thinking that the test should be to check that both columns in the "battery bus" of the timeseries_all_busses.xlsx are always 0 at any timesteps (i.e. the battery is never used). I am not sure right now whether it is 0 because I wrote a wrong input file or because it is indeed 0 as expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smartie2076 - I was thinking that the test should be to check that both columns in the "battery bus" of the timeseries_all_busses.xlsx are always 0 at any timesteps (i.e. the battery is never used). I am not sure right now whether it is 0 because I wrote a wrong input file or because it is indeed 0 as expected.
You are right, it should be zero as using the battery would require 1/(0.95*0.95) times more electricity than directly from the DSO to supply a demand.
I have added some comments.
capex_var,currency/kW,0 | ||
efficiency,factor,0.96 | ||
inflow_direction,str,Electricity (DSO) | ||
installedCap,kW,1250 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
installedCap,kW,1250 | |
installedCap,kW,1250 |
What is the peak of your demand profile? If it is >1250 kW, the benchmark should fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is 1000 kW
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That could be an easy benchmark test, that the simulation should fail if the demand is higher than the installedCap, should that trigger a warning?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That benchmark should only fail if there are no potential internal generation assets.
In the MVS´ applicaiton, we are dealing with energy half-islands, which sometimes do not want to change an existing transformer station but instead install some more internal generation capacities.
tests/benchmark_test_inputs/AE/csv_elements/simulation_settings.csv
Outdated
Show resolved
Hide resolved
tests/benchmark_test_inputs/AE/csv_elements/simulation_settings.csv
Outdated
Show resolved
Hide resolved
tests/benchmark_test_inputs/AE/csv_elements/simulation_settings.csv
Outdated
Show resolved
Hide resolved
,unit,distribution_grid,engineering,operation | ||
age_installed,year,10, 0, 0 | ||
capex_fix,currency,0.0,0,0 | ||
capex_var,currency,0.0,0,0 | ||
label,str,distribution grid infrastructure,"R&D, engineering",Fix project operation | ||
lifetime,year,30,20,20 | ||
opex_fix,currency/year,0,0,4600 | ||
opex_var,currency/kWh,0,0,0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please delete the three columns distribution_grid, engineering, operation, as they are currently not used in our calculations.
I thought I deleted that everywhere I could....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so then it means that the entire fixcost.csv file is not useful, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, that is sadly true.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah... sadly that currently is true. I was thinking that in the future it would be nice.
Linked to issue #106
Co-authored-by: smartie2076 <44204527+smartie2076@users.noreply.github.com>
da1c43d
to
6a636be
Compare
Linked to #106
Changes proposed in this pull request:
Add a benchmark test for grid + battery
The following steps were realized, as well (if applies):
black . --exclude docs/
)pytest tests/test_benchmark.py
)For more information on how to contribute check the CONTRIBUTING.md.