Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validation scheme #306

Merged
merged 10 commits into from May 12, 2020
Merged

Validation scheme #306

merged 10 commits into from May 12, 2020

Conversation

ursulaelmir
Copy link
Collaborator

@ursulaelmir ursulaelmir commented May 11, 2020 •
edited

Fix #296

Changes proposed in this pull request:
Add validation plan to readthedocs

The following steps were realized, as well (if applies):

  • Update the CHANGELOG.md
  • Apply black (black . --exclude docs/)

For more information on how to contribute check the CONTRIBUTING.md.

@ursulaelmir ursulaelmir mentioned this pull request May 11, 2020
Closed
smartie2076
smartie2076 approved these changes May 12, 2020
View reviewed changes
Copy link
Collaborator

@smartie2076 smartie2076 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, can be merged into dev!

CHANGELOG.md Outdated Show resolved Hide resolved
docs/Overview.rst Outdated Show resolved Hide resolved
docs/Overview.rst Outdated Show resolved Hide resolved
docs/Overview.rst Outdated Show resolved Hide resolved
@smartie2076
Copy link
Collaborator

I just realised that you have not used the PR template (or did it not appear?). It is important to do so so that in larger/complex PR people now which issues are fixed and what is changed. Basically, you can copy that compilation to the CHANGELOG.md when your done. Please reference #302, it shows how the PR text should look like.

ursulaelmir and others added 2 commits May 12, 2020 16:50
@ursulaelmir @smartie2076
Update CHANGELOG.md
031bfa6 
Co-authored-by: smartie2076 <44204527+smartie2076@users.noreply.github.com>
@ursulaelmir @smartie2076
Embolden validation types
368e9b2 
Co-authored-by: smartie2076 <44204527+smartie2076@users.noreply.github.com>
@ursulaelmir ursulaelmir marked this pull request as ready for review May 12, 2020 14:55
@ursulaelmir ursulaelmir marked this pull request as ready for review May 12, 2020 15:04
@ursulaelmir ursulaelmir marked this pull request as ready for review May 12, 2020 15:15
@ursulaelmir ursulaelmir marked this pull request as ready for review May 12, 2020 15:24
@ursulaelmir ursulaelmir marked this pull request as ready for review May 12, 2020 18:56
@ursulaelmir ursulaelmir merged commit 54b23f1 into dev May 12, 2020
@smartie2076 smartie2076 deleted the Validation-scheme branch May 20, 2020 07:26
@Bachibouzouk Bachibouzouk mentioned this pull request May 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smartie2076 smartie2076 smartie2076 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Documentation] MVS validation plan
2 participants
@ursulaelmir @smartie2076