Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work in progress: test fast-feed on OS X with Travis build #28

Closed
vielmetti opened this issue Sep 15, 2015 · 7 comments
Closed

Work in progress: test fast-feed on OS X with Travis build #28

vielmetti opened this issue Sep 15, 2015 · 7 comments

Comments

@vielmetti
Copy link
Contributor

The goal is to have Travis build fast-feed on OS X and have tests pass.

The corresponding PR is #27 and it's failing all of the OS X tests now because I haven't sorted out the Mac environment yet for Travis for node, so it's not at all ready for merge.

It looks like node-sqlite has got the environment set sorted out, here:

https://github.com/mapbox/node-sqlite3/blob/master/.travis.yml

so I know it's doable:

https://travis-ci.org/mapbox/node-sqlite3

thanks!

@rla
Copy link
Owner

rla commented Sep 15, 2015

Cross-referencing related issue from Travis repo: travis-ci/travis-ci#2311

@vielmetti
Copy link
Contributor Author

Thanks @rla . It looks like there's a couple of ways this might be done; hoping to get a strategy that's maximally readable and also compact.

@vielmetti
Copy link
Contributor Author

The node-sass approach to this at https://github.com/sass/node-sass/blob/master/.travis.yml looks better than the node-sqlite3 approach. Their discussion is in a pull request: sass/node-sass#1137

@vielmetti
Copy link
Contributor Author

I followed the node-sass approach, and now #27 is ready to merge - all tests are green.

@vielmetti
Copy link
Contributor Author

PR #27 has been merged, closing this.

@vielmetti
Copy link
Contributor Author

Thanks for all of your help on this @rla . I wrote this up http://vielmetti.github.io/post/2015/2015-09-16-travis-ci/ to describe and capture bits of what I've learned. I realize now that I should go back and edit in links to your blog posts on the topic, will do that next.

@rla
Copy link
Owner

rla commented Sep 18, 2015

@vielmetti it would be worth mentioning that CI does not only test master for non-broken code but (feature) branches as well (or PRs in case of GitHub). I think that's where "integration" in CI comes from. For GitHub it's super-useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants