-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run OSX builds in Travis CI #1137
Conversation
fea6b96
to
378a1c8
Compare
There is nothing to think about :) only to act! I think we should work in this direction - and maybe whenever a tag is pushed we should be prepared to do a full run on OS X to create & deploy binaries. One question - why do you need to install python from homebrew? something is not working? |
This is brilliant! 👍 |
That's the plan. Ideally I want to wire this and your AppVeyor work into node-pre-gyp
This as frustratingly slow. I double the number of simultaneous builds in Travis but didn't help too much. |
node-gyp wants python2 in the path. This isn't present by default but |
de2de4b
to
bdc8006
Compare
Turns out this is possible with
No more |
bdc8006
to
5ded6ed
Compare
Not running |
Wow! This is already in excellent shape. Lets merge it then! Further improvements can continue to follow over time. 😄 |
I think that eventual migration to From the context I presume you would like to use I'd love to use One thing to decide before we go ahead with either solution is that should agree first how to trigger the release build - is having a separate The only reason we might need a separate branch is http://bit.ly/twoBuilds issue - with a separate branch I can configure package building on commit push instead of tag push. |
I agree. Just something I want us to keep in mind.
IIRC
I have previous suggested we (libsass) adopt a Personally this is something I would prefer to avoid.
Does this not help? https://help.appveyor.com/discussions/questions/261-only-deploy-when-theres-a-new-tag#comment_37132177 |
On Mon, 14 Sep 2015, Michael Mifsud wrote:
node-pre-gyp does not seem to care which CI platform
Me too. But for now(?) we could just make "release" to fully mirror
Nope, see my comment below ... it triggers a while build on the release
I know it sounds complicated, I hope Fedor somehow responds to that... |
Fix comment_to_string edge case
----- It is inappropriate to include political and offensive content in public code repositories. Public code repositories should be neutral spaces for collaboration and community, free from personal or political views that could alienate or discriminate against others. Political content, especially that which targets or disparages minority groups, can be harmful and divisive. It can make people feel unwelcome and unsafe, and it can create a hostile work environment. Please refrain from adding such content to public code repositories.
I've been following travis-ci/travis-ci#2311 and it seems like getting a node project to build on OSX should be doable with some persistence.
I'm mostly just PR'ing this so Travis will build it. Feel free to ignore for the time being. This could be a complete failure.It took a bit of doing but this works! I'm only building OSX for 0.12 and 4 for now to keep builds quicky-ish.